Parameter type has to have the same type as parameters with described allowed constants to report passed constant as an error

Author: ondrejmirtes

src/Rules/FunctionCallParametersCheck.php

@@ -108,14 +108,13 @@ public function check(
 
 		$functionParametersMinCount = 0;
 		$functionParametersMaxCount = 0;
-		$hasAllowedConstants = false;
+		$allowedConstantsTypes = [];
 		foreach ($parametersAcceptor->getParameters() as $parameter) {
 			if (
 				$parameter instanceof ExtendedParameterReflection
-				&& !$hasAllowedConstants
 				&& $parameter->getAllowedConstants() !== null
 			) {
-				$hasAllowedConstants = true;
+				$allowedConstantsTypes[] = $parameter->getType();
 			}
 			if (!$parameter->isOptional()) {
 				$functionParametersMinCount++;
@@ -124,6 +123,11 @@ public function check(
 			$functionParametersMaxCount++;
 		}
 
+		$allowedConstantsType = null;
+		if (count($allowedConstantsTypes) > 0) {
+			$allowedConstantsType = TypeCombinator::union(...$allowedConstantsTypes);
+		}
+
 		if ($parametersAcceptor->isVariadic()) {
 			$functionParametersMaxCount = -1;
 		}
@@ -469,7 +473,7 @@ public function check(
 									->line($argumentLine)
 									->build();
 							}
-						} elseif ($isBuiltin && $hasAllowedConstants) {
+						} elseif ($isBuiltin && $allowedConstantsType !== null && $allowedConstantsType->isSuperTypeOf($parameterType)->yes()) {
 							foreach ($constantReflections as $constantReflection) {
 								if ($constantReflection->isBuiltin()->no()) {
 									continue;

tests/PHPStan/Rules/Functions/data/constant-parameter-check.php

@@ -102,3 +102,6 @@ public function hashPassword(string $password): string
 json_decode($json, true);
 json_decode($json, null);
 json_decode($json, false);
+
+// PHP_OS passed to $subject of preg_match - should not report
+preg_match('/foo/', PHP_OS);