ClassNameCheck: Retrieve extensions just once (#4926)

staabm · web-flow · commit f1793820dc5a · 2026-02-18T10:03:47.000+01:00
diff --git a/src/Rules/ClassNameCheck.php b/src/Rules/ClassNameCheck.php
@@ -12,6 +12,9 @@
 final class ClassNameCheck
 {
 
+	/** @var RestrictedClassNameUsageExtension[] $extensions */
+	private ?array $extensions = null;
+
 	public function __construct(
 		private ClassCaseSensitivityCheck $classCaseSensitivityCheck,
 		private ClassForbiddenNameCheck $classForbiddenNameCheck,
@@ -47,8 +50,7 @@ public function checkClassNames(
 			return $errors;
 		}
 
-		/** @var RestrictedClassNameUsageExtension[] $extensions */
-		$extensions = $this->container->getServicesByTag(RestrictedClassNameUsageExtension::CLASS_NAME_EXTENSION_TAG);
+		$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedClassNameUsageExtension::CLASS_NAME_EXTENSION_TAG);
 		if ($extensions === []) {
 			return $errors;
 		}
diff --git a/src/Rules/RestrictedUsage/RestrictedClassConstantUsageRule.php b/src/Rules/RestrictedUsage/RestrictedClassConstantUsageRule.php
@@ -22,6 +22,9 @@
 final class RestrictedClassConstantUsageRule implements Rule
 {
 
+	/** @var RestrictedClassConstantUsageExtension[] $extensions */
+	private ?array $extensions = null;
+
 	public function __construct(
 		private Container $container,
 		private ReflectionProvider $reflectionProvider,
@@ -44,8 +47,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		/** @var RestrictedClassConstantUsageExtension[] $extensions */
-		$extensions = $this->container->getServicesByTag(RestrictedClassConstantUsageExtension::CLASS_CONSTANT_EXTENSION_TAG);
+		$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedClassConstantUsageExtension::CLASS_CONSTANT_EXTENSION_TAG);
 		if ($extensions === []) {
 			return [];
 		}
diff --git a/src/Rules/RestrictedUsage/RestrictedFunctionCallableUsageRule.php b/src/Rules/RestrictedUsage/RestrictedFunctionCallableUsageRule.php
@@ -19,6 +19,9 @@
 final class RestrictedFunctionCallableUsageRule implements Rule
 {
 
+	/** @var RestrictedFunctionUsageExtension[] $extensions */
+	private ?array $extensions = null;
+
 	public function __construct(
 		private Container $container,
 		private ReflectionProvider $reflectionProvider,
@@ -46,8 +49,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$functionReflection = $this->reflectionProvider->getFunction($node->getName(), $scope);
 
-		/** @var RestrictedFunctionUsageExtension[] $extensions */
-		$extensions = $this->container->getServicesByTag(RestrictedFunctionUsageExtension::FUNCTION_EXTENSION_TAG);
+		$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedFunctionUsageExtension::FUNCTION_EXTENSION_TAG);
 		$errors = [];
 
 		foreach ($extensions as $extension) {
diff --git a/src/Rules/RestrictedUsage/RestrictedFunctionUsageRule.php b/src/Rules/RestrictedUsage/RestrictedFunctionUsageRule.php
@@ -18,6 +18,9 @@
 final class RestrictedFunctionUsageRule implements Rule
 {
 
+	/** @var RestrictedFunctionUsageExtension[] $extensions */
+	private ?array $extensions = null;
+
 	public function __construct(
 		private Container $container,
 		private ReflectionProvider $reflectionProvider,
@@ -45,8 +48,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$functionReflection = $this->reflectionProvider->getFunction($node->name, $scope);
 
-		/** @var RestrictedFunctionUsageExtension[] $extensions */
-		$extensions = $this->container->getServicesByTag(RestrictedFunctionUsageExtension::FUNCTION_EXTENSION_TAG);
+		$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedFunctionUsageExtension::FUNCTION_EXTENSION_TAG);
 		$errors = [];
 
 		foreach ($extensions as $extension) {
diff --git a/src/Rules/RestrictedUsage/RestrictedMethodCallableUsageRule.php b/src/Rules/RestrictedUsage/RestrictedMethodCallableUsageRule.php
@@ -19,6 +19,9 @@
 final class RestrictedMethodCallableUsageRule implements Rule
 {
 
+	/** @var RestrictedMethodUsageExtension[] $extensions */
+	private ?array $extensions = null;
+
 	public function __construct(
 		private Container $container,
 		private ReflectionProvider $reflectionProvider,
@@ -40,8 +43,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		/** @var RestrictedMethodUsageExtension[] $extensions */
-		$extensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
+		$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
 		if ($extensions === []) {
 			return [];
 		}
diff --git a/src/Rules/RestrictedUsage/RestrictedMethodUsageRule.php b/src/Rules/RestrictedUsage/RestrictedMethodUsageRule.php
@@ -19,6 +19,9 @@
 final class RestrictedMethodUsageRule implements Rule
 {
 
+	/** @var RestrictedMethodUsageExtension[] $extensions */
+	private ?array $extensions = null;
+
 	public function __construct(
 		private Container $container,
 		private ReflectionProvider $reflectionProvider,
@@ -40,8 +43,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		/** @var RestrictedMethodUsageExtension[] $extensions */
-		$extensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
+		$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
 		if ($extensions === []) {
 			return [];
 		}
diff --git a/src/Rules/RestrictedUsage/RestrictedPropertyUsageRule.php b/src/Rules/RestrictedUsage/RestrictedPropertyUsageRule.php
@@ -18,6 +18,9 @@
 final class RestrictedPropertyUsageRule implements Rule
 {
 
+	/** @var RestrictedPropertyUsageExtension[] $extensions */
+	private ?array $extensions = null;
+
 	public function __construct(
 		private Container $container,
 		private ReflectionProvider $reflectionProvider,
@@ -39,8 +42,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		/** @var RestrictedPropertyUsageExtension[] $extensions */
-		$extensions = $this->container->getServicesByTag(RestrictedPropertyUsageExtension::PROPERTY_EXTENSION_TAG);
+		$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedPropertyUsageExtension::PROPERTY_EXTENSION_TAG);
 		if ($extensions === []) {
 			return [];
 		}
diff --git a/src/Rules/RestrictedUsage/RestrictedStaticMethodCallableUsageRule.php b/src/Rules/RestrictedUsage/RestrictedStaticMethodCallableUsageRule.php
@@ -23,6 +23,9 @@
 final class RestrictedStaticMethodCallableUsageRule implements Rule
 {
 
+	/** @var RestrictedMethodUsageExtension[] $extensions */
+	private ?array $extensions = null;
+
 	public function __construct(
 		private Container $container,
 		private ReflectionProvider $reflectionProvider,
@@ -45,8 +48,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		/** @var RestrictedMethodUsageExtension[] $extensions */
-		$extensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
+		$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
 		if ($extensions === []) {
 			return [];
 		}
diff --git a/src/Rules/RestrictedUsage/RestrictedStaticMethodUsageRule.php b/src/Rules/RestrictedUsage/RestrictedStaticMethodUsageRule.php
@@ -22,6 +22,9 @@
 final class RestrictedStaticMethodUsageRule implements Rule
 {
 
+	/** @var RestrictedMethodUsageExtension[] $extensions */
+	private ?array $extensions = null;
+
 	public function __construct(
 		private Container $container,
 		private ReflectionProvider $reflectionProvider,
@@ -44,8 +47,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		/** @var RestrictedMethodUsageExtension[] $extensions */
-		$extensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
+		$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
 		if ($extensions === []) {
 			return [];
 		}
diff --git a/src/Rules/RestrictedUsage/RestrictedStaticPropertyUsageRule.php b/src/Rules/RestrictedUsage/RestrictedStaticPropertyUsageRule.php
@@ -22,6 +22,9 @@
 final class RestrictedStaticPropertyUsageRule implements Rule
 {
 
+	/** @var RestrictedPropertyUsageExtension[] $extensions */
+	private ?array $extensions = null;
+
 	public function __construct(
 		private Container $container,
 		private ReflectionProvider $reflectionProvider,
@@ -44,8 +47,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		/** @var RestrictedPropertyUsageExtension[] $extensions */
-		$extensions = $this->container->getServicesByTag(RestrictedPropertyUsageExtension::PROPERTY_EXTENSION_TAG);
+		$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedPropertyUsageExtension::PROPERTY_EXTENSION_TAG);
 		if ($extensions === []) {
 			return [];
 		}
diff --git a/src/Rules/RestrictedUsage/RestrictedUsageOfDeprecatedStringCastRule.php b/src/Rules/RestrictedUsage/RestrictedUsageOfDeprecatedStringCastRule.php
@@ -18,6 +18,9 @@
 final class RestrictedUsageOfDeprecatedStringCastRule implements Rule
 {
 
+	/** @var RestrictedMethodUsageExtension[] $extensions */
+	private ?array $extensions = null;
+
 	public function __construct(
 		private Container $container,
 		private ReflectionProvider $reflectionProvider,
@@ -32,8 +35,7 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		/** @var RestrictedMethodUsageExtension[] $extensions */
-		$extensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
+		$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
 		if ($extensions === []) {
 			return [];
 		}

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,9 @@`
`12`	`12`	`final class ClassNameCheck`
`13`	`13`	`{`
`14`	`14`
	`15`	`+ /** @var RestrictedClassNameUsageExtension[] $extensions */`
	`16`	`+ private ?array $extensions = null;`
	`17`	`+`
`15`	`18`	`public function __construct(`
`16`	`19`	`private ClassCaseSensitivityCheck $classCaseSensitivityCheck,`
`17`	`20`	`private ClassForbiddenNameCheck $classForbiddenNameCheck,`
`@@ -47,8 +50,7 @@ public function checkClassNames(`
`47`	`50`	`return $errors;`
`48`	`51`	`}`
`49`	`52`
`50`		`- /** @var RestrictedClassNameUsageExtension[] $extensions */`
`51`		`- $extensions = $this->container->getServicesByTag(RestrictedClassNameUsageExtension::CLASS_NAME_EXTENSION_TAG);`
	`53`	`+ $extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedClassNameUsageExtension::CLASS_NAME_EXTENSION_TAG);`
`52`	`54`	`if ($extensions === []) {`
`53`	`55`	`return $errors;`
`54`	`56`	`}`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,9 @@`
`22`	`22`	`final class RestrictedClassConstantUsageRule implements Rule`
`23`	`23`	`{`
`24`	`24`
	`25`	`+ /** @var RestrictedClassConstantUsageExtension[] $extensions */`
	`26`	`+ private ?array $extensions = null;`
	`27`	`+`
`25`	`28`	`public function __construct(`
`26`	`29`	`private Container $container,`
`27`	`30`	`private ReflectionProvider $reflectionProvider,`
`@@ -44,8 +47,7 @@ public function processNode(Node $node, Scope $scope): array`
`44`	`47`	`return [];`
`45`	`48`	`}`
`46`	`49`
`47`		`- /** @var RestrictedClassConstantUsageExtension[] $extensions */`
`48`		`- $extensions = $this->container->getServicesByTag(RestrictedClassConstantUsageExtension::CLASS_CONSTANT_EXTENSION_TAG);`
	`50`	`+ $extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedClassConstantUsageExtension::CLASS_CONSTANT_EXTENSION_TAG);`
`49`	`51`	`if ($extensions === []) {`
`50`	`52`	`return [];`
`51`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,9 @@`
`19`	`19`	`final class RestrictedMethodCallableUsageRule implements Rule`
`20`	`20`	`{`
`21`	`21`
	`22`	`+ /** @var RestrictedMethodUsageExtension[] $extensions */`
	`23`	`+ private ?array $extensions = null;`
	`24`	`+`
`22`	`25`	`public function __construct(`
`23`	`26`	`private Container $container,`
`24`	`27`	`private ReflectionProvider $reflectionProvider,`
`@@ -40,8 +43,7 @@ public function processNode(Node $node, Scope $scope): array`
`40`	`43`	`return [];`
`41`	`44`	`}`
`42`	`45`
`43`		`- /** @var RestrictedMethodUsageExtension[] $extensions */`
`44`		`- $extensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);`
	`46`	`+ $extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);`
`45`	`47`	`if ($extensions === []) {`
`46`	`48`	`return [];`
`47`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,9 @@`
`18`	`18`	`final class RestrictedPropertyUsageRule implements Rule`
`19`	`19`	`{`
`20`	`20`
	`21`	`+ /** @var RestrictedPropertyUsageExtension[] $extensions */`
	`22`	`+ private ?array $extensions = null;`
	`23`	`+`
`21`	`24`	`public function __construct(`
`22`	`25`	`private Container $container,`
`23`	`26`	`private ReflectionProvider $reflectionProvider,`
`@@ -39,8 +42,7 @@ public function processNode(Node $node, Scope $scope): array`
`39`	`42`	`return [];`
`40`	`43`	`}`
`41`	`44`
`42`		`- /** @var RestrictedPropertyUsageExtension[] $extensions */`
`43`		`- $extensions = $this->container->getServicesByTag(RestrictedPropertyUsageExtension::PROPERTY_EXTENSION_TAG);`
	`45`	`+ $extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedPropertyUsageExtension::PROPERTY_EXTENSION_TAG);`
`44`	`46`	`if ($extensions === []) {`
`45`	`47`	`return [];`
`46`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,9 @@`
`23`	`23`	`final class RestrictedStaticMethodCallableUsageRule implements Rule`
`24`	`24`	`{`
`25`	`25`
	`26`	`+ /** @var RestrictedMethodUsageExtension[] $extensions */`
	`27`	`+ private ?array $extensions = null;`
	`28`	`+`
`26`	`29`	`public function __construct(`
`27`	`30`	`private Container $container,`
`28`	`31`	`private ReflectionProvider $reflectionProvider,`
`@@ -45,8 +48,7 @@ public function processNode(Node $node, Scope $scope): array`
`45`	`48`	`return [];`
`46`	`49`	`}`
`47`	`50`
`48`		`- /** @var RestrictedMethodUsageExtension[] $extensions */`
`49`		`- $extensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);`
	`51`	`+ $extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);`
`50`	`52`	`if ($extensions === []) {`
`51`	`53`	`return [];`
`52`	`54`	`}`