Skip to content

Comments

faq: correct fio examples for psync#21383

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
hbisheng:fio-iodepth-and-ioengine
Feb 25, 2026
Merged

faq: correct fio examples for psync#21383
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
hbisheng:fio-iodepth-and-ioengine

Conversation

@hbisheng
Copy link
Contributor

@hbisheng hbisheng commented Feb 25, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Use direct=1 instead of fdatasync=1 to avoid page cache interference

  • Set iodepth=1 since psync is synchronous (concurrency comes from numjobs)

  • Add time_based to ensure runtime=60 is honored

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

- Use direct=1 instead of fdatasync=1 to avoid page cache interference

- Set iodepth=1 since psync is synchronous (concurrency comes from numjobs)

- Add time_based to ensure runtime=60 is honored
@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Feb 25, 2026
@pingcap-cla-assistant
Copy link

pingcap-cla-assistant bot commented Feb 25, 2026

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 25, 2026
@hfxsd hfxsd self-assigned this Feb 25, 2026
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2026
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Feb 25, 2026
@hfxsd hfxsd requested a review from qiancai February 25, 2026 06:38
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 25, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 25, 2026

@LykxSassinator: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 25, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-25 06:40:46.283733878 +0000 UTC m=+250718.798528477: ☑️ agreed by qiancai.
  • 2026-02-25 06:50:06.190346243 +0000 UTC m=+251278.705140862: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Collaborator

hfxsd commented Feb 25, 2026

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Feb 25, 2026
@hfxsd hfxsd closed this Feb 25, 2026
@hfxsd hfxsd reopened this Feb 25, 2026
@hfxsd
Copy link
Collaborator

hfxsd commented Feb 25, 2026

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hfxsd hfxsd closed this Feb 25, 2026
@hfxsd hfxsd reopened this Feb 25, 2026
@hfxsd hfxsd closed this Feb 25, 2026
@hfxsd hfxsd reopened this Feb 25, 2026
@ti-chi-bot ti-chi-bot bot merged commit c5f0ec8 into pingcap:master Feb 25, 2026
27 of 28 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #21387.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

在用 fio 命令测试 TiKV 实例的磁盘性能时当ioengine=psync设置iodepth=4是无意义的

5 participants