fix: uniqness od scenarios in Comapre tab

Author: piotrlangowski

src/lib/shared/db-schema.ts

@@ -1078,4 +1078,28 @@ function runDataMigrations(db: DatabaseConnection): void {
     db.prepare("ALTER TABLE pool_tiers ADD COLUMN pool_size_basis TEXT NOT NULL DEFAULT 'absolute'").run();
     db.prepare("DELETE FROM scenario_results WHERE scenario_id IN (SELECT id FROM scenarios WHERE pool_tier_id IS NOT NULL)").run();
   }
+
+  // Migration 24: scenario_results never had a uniqueness constraint on scenario_id, and
+  // saveResults() always generates a fresh row id, so every recalculation left the previous
+  // cached row orphaned instead of replacing it. Duplicate rows made a single scenario appear
+  // multiple times anywhere that LEFT JOINs scenario_results (e.g. scenariosRepository.getAll(),
+  // used by the scenarios list and Compare pages). Dedup down to the most recent row per
+  // scenario, then add a UNIQUE index so INSERT OR REPLACE correctly upserts on scenario_id.
+  const scenarioResultsIndex24 = db.prepare(
+    `SELECT name FROM sqlite_master WHERE type = 'index' AND name = 'idx_scenario_results_scenario_id'`
+  ).get();
+  if (!scenarioResultsIndex24) {
+    db.prepare(`
+      DELETE FROM scenario_results
+      WHERE rowid NOT IN (
+        SELECT MAX(r.rowid)
+        FROM scenario_results r
+        WHERE r.calculated_at = (
+          SELECT MAX(r2.calculated_at) FROM scenario_results r2 WHERE r2.scenario_id = r.scenario_id
+        )
+        GROUP BY r.scenario_id
+      )
+    `).run();
+    db.prepare(`CREATE UNIQUE INDEX idx_scenario_results_scenario_id ON scenario_results(scenario_id)`).run();
+  }
 }

src/routes/scenarios/[id]/+page.svelte

@@ -25,6 +25,7 @@
   import Edit2 from '@lucide/svelte/icons/edit-2';
   import DollarSign from '@lucide/svelte/icons/dollar-sign';
   import AlertTriangle from '@lucide/svelte/icons/alert-triangle';
+  import Route from '@lucide/svelte/icons/route';
   import ExportButton from '$lib/components/dashboard/ExportButton.svelte';
   import DiagnosticsBanner from '$lib/components/dashboard/DiagnosticsBanner.svelte';
 
@@ -38,6 +39,15 @@
   const scopeSummary = $derived(data.scopeSummary);
   const resolvedConfigs = $derived(data.resolvedConfigs || []);
 
+  const modelingTypeLabel = $derived.by(() => {
+    switch (scenario.modeling_type) {
+      case 'incremental': return 'Incremental';
+      case 'gtm': return 'GTM';
+      case 'appraisal': return 'Appraisal';
+      default: return 'Appraisal';
+    }
+  });
+
   const diagnostics = $derived(data.diagnostics ?? []);
 
   // ADR 0009 — per-archetype stream economics (mix signal)
@@ -1370,6 +1380,12 @@
 
   {#if scopeSummary}
     <div class="glass border border-border px-4 py-2.5 rounded-lg flex items-center space-x-2 text-xs select-none">
+      <Route class="h-4 w-4 text-primary shrink-0" />
+      <span class="text-muted-foreground font-semibold">Type:</span>
+      <Badge variant="outline" class="glass-inset py-0.5 px-2 font-semibold">
+        {modelingTypeLabel}
+      </Badge>
+      <span class="text-muted-foreground/60">•</span>
       <Users2 class="h-4 w-4 text-primary shrink-0" />
       <span class="text-muted-foreground font-semibold">Scope Targeting:</span>
       <Badge variant="outline" class="glass-inset py-0.5 px-2 capitalize font-semibold">