Skip to content

Refactor commands to use cleaner interface #140

@hasheddan

Description

@hasheddan

Currently, corral commands are passed to the Executor primitive along with a few other parameters that eventually effect what is being passed to the command's apply() method. This makes unit testing difficult as the parameters that are passed to the Executor are used for common checks across all commands before then being passed to the commands themselves.

A cleaner interface could look like initiating a CmdType with all (or most) of the parameters currently being passed to the Executor (and then subsequently to the CmdType apply()) or having separate CmdTypeInfo and CmdTypeAction traits that are initiated and will choose some of these parameters for you by default (e.g. the Logger).

Related to #138

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions