-
Notifications
You must be signed in to change notification settings - Fork 225
Closing popups requires two Esc key presses #2118
Copy link
Copy link
Open
Description
In KDE Plasma or GNOME, we can press Escape key to close a popup menu in applications like featherpad and gedit. However, in cosmic-comp, it requires two key presses of Escape key. I think the cause is that cosmic-comp consumes the first press of Escape key to finish popup grab and the applications cannot see the key press:
Lines 1762 to 1781 in ef14b7e
| // cancel grabs | |
| if is_grabbed | |
| && handle.modified_sym() == Keysym::Escape | |
| && event.state() == KeyState::Pressed | |
| && !modifiers.alt | |
| && !modifiers.ctrl | |
| && !modifiers.logo | |
| && !modifiers.shift | |
| { | |
| seat.supressed_keys().add(&handle, None); | |
| return FilterResult::Intercept(Some(( | |
| Action::Private(PrivateAction::Escape), | |
| shortcuts::Binding { | |
| modifiers: shortcuts::Modifiers::default(), | |
| keycode: None, | |
| key: Some(Keysym::Escape), | |
| description: None, | |
| }, | |
| ))); | |
| } |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels