Skip to content

Cleanup key remapping technique #83

@alerque

Description

@alerque

The merge of #50 accomplished something positive (allowing people with rebound motion keys to keep using their preferred key rather than the hard coded defaults) but it also introduced a regression. In fixing the regression (see #82) I observed there are several more potential problems lurking in this method.

First, Mapkey() should be refactored completely so it queries the map for a single binding rather than iterating though the entire map parsing for bindings itself.

Second, we're completely inconsistent about what keys we account for possibly having been user remapped and which we don't. I think the entire things should be fixed so that all keys respect what users may have mapped them to and Pencil's behavior gets added to their preferred mappings with no hard coded keys at all.

Third, their doesn't seem to be a reliable way to turn off all the Pencil modified bindings at once. Most of them get reverted, but not quite all. And now that we're looking an what user mappings were, we need to revert to those not just revert to hard coded defaults!

I'm opening this as an issue because I won't be able to get to this soon (traveling for a couple weeks) and don't want to loose track of things I noticed needed attention.

Possibly related: #34.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions