Skip to content

FastGelu custom htp kernel#15507

Open
cccclai wants to merge 4 commits intomainfrom
fastgelu
Open

FastGelu custom htp kernel#15507
cccclai wants to merge 4 commits intomainfrom
fastgelu

Conversation

@cccclai
Copy link
Copy Markdown
Contributor

@cccclai cccclai commented Nov 1, 2025

python3 examples/qualcomm/custom_op/custom_ops_fast_gelu.py --build_folder build-android  -m SM8750 --op_package_dir examples/qualcomm/custom_op/fastgelu_op_package_htp/FastGeluOpPackage --build_op_package 

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15507

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures, 1 Unrelated Failure

As of commit 5347bce with merge base f81d768 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cccclai cccclai marked this pull request as draft November 1, 2025 17:16
@cccclai cccclai marked this pull request as ready for review November 6, 2025 21:02
@cccclai
Copy link
Copy Markdown
Contributor Author

cccclai commented Nov 6, 2025

Hi team, I add a FastGelu example, but I didn't use HTP intrinsics so the perf is still not optimized. Would like to know where to put these examples

@cccclai
Copy link
Copy Markdown
Contributor Author

cccclai commented Nov 14, 2025

Can I get a review on this PR?

@shewu-quic
Copy link
Copy Markdown
Collaborator

Hi team, I add a FastGelu example, but I didn't use HTP intrinsics so the perf is still not optimized. Would like to know where to put these examples

Thanks for your contribution. I think it is ok to put this custom op in examples/qualcomm/custom_op.

@github-actions
Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Jan 17, 2026
@github-actions
Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 11, 2026

Hi @cccclai!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants