Qualcomm AI Engine Direct - Adding QNN backend support for the remainder core ATen ops#18843
Conversation
|
@pytorchbot label "release notes: qualcomm" |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18843
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 21 PendingAs of commit 60492e4 with merge base eaef2ed ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
abhinaykukkadapu
left a comment
There was a problem hiding this comment.
@qti-horodnic thanks for adding support, wondering if you've tried the skills from @shewu-quic latest PR, curious if we can improve them if you see any gaps.
Thanks for bringing this up, I have not tried them yet. Let me look into it and I'll follow up |
Summary
Added support for the aten ops
remainder.Scalarandremainder.Tensorusing a decomposition pass via the identity:remainder(x, y) = x - floor(x / y) * yAlso did a minor refactor for the
acosandlog_variantsunit tests, to combine all cases into a single test similarly to how other op tests were previously implemented.Test plan
For the refactored
acosandlog_variantstests: