Skip to content

Qualcomm AI Engine Direct - Adding QNN backend support for the remainder core ATen ops#18843

Merged
abhinaykukkadapu merged 1 commit intopytorch:mainfrom
CodeLinaro:remainder
Apr 15, 2026
Merged

Qualcomm AI Engine Direct - Adding QNN backend support for the remainder core ATen ops#18843
abhinaykukkadapu merged 1 commit intopytorch:mainfrom
CodeLinaro:remainder

Conversation

@qti-horodnic
Copy link
Copy Markdown
Contributor

Summary

Added support for the aten ops remainder.Scalar and remainder.Tensor using a decomposition pass via the identity:

remainder(x, y) = x - floor(x / y) * y

Also did a minor refactor for the acos and log_variants unit tests, to combine all cases into a single test similarly to how other op tests were previously implemented.

Test plan

python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNQuantizedOperator.test_qnn_backend_remainder --model SM8750 --host aisw-vm16-labsd --device 4a8bfec7 --build_folder build-android
python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNFloatingPointOperator.test_qnn_backend_remainder --model SM8750 --host aisw-vm16-labsd --device 4a8bfec7 --build_folder build-android

For the refactored acos and log_variants tests:

python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNQuantizedOperator.test_qnn_backend_acos --model SM8750 --host aisw-vm16-labsd --device 4a8bfec7 --build_folder build-android
python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNFloatingPointOperator.test_qnn_backend_acos --model SM8750 --host aisw-vm16-labsd --device 4a8bfec7 --build_folder build-android

python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNQuantizedOperator.test_qnn_backend_log_variants --model SM8750 --host aisw-vm16-labsd --device 4a8bfec7 --build_folder build-android
python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNFloatingPointOperator.test_qnn_backend_log_variants --model SM8750 --host aisw-vm16-labsd --device 4a8bfec7 --build_folder build-android

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 13, 2026
@qti-horodnic
Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Apr 13, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 13, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18843

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 21 Pending

As of commit 60492e4 with merge base eaef2ed (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Copy Markdown
Contributor

@abhinaykukkadapu abhinaykukkadapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qti-horodnic thanks for adding support, wondering if you've tried the skills from @shewu-quic latest PR, curious if we can improve them if you see any gaps.

@abhinaykukkadapu abhinaykukkadapu merged commit f35fbb5 into pytorch:main Apr 15, 2026
158 of 161 checks passed
@qti-horodnic
Copy link
Copy Markdown
Contributor Author

@qti-horodnic thanks for adding support, wondering if you've tried the skills from @shewu-quic latest PR, curious if we can improve them if you see any gaps.

Thanks for bringing this up, I have not tried them yet. Let me look into it and I'll follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants