Add vector layer based on Protocol - GeoJSON not anymore available

[Roumagnifique]

Feature description

Hello,
After le the QGIS release 3.16., we are not able to add a Geojson url as a vector on windows. On Ubuntu, the feature is still available. Could it be possible to restore this feature on windowe?

Best regards

Additional context

No response

[nicogodet]

ping @jef-n @rouault packaging issue ?

[agiudiceandrea]

@nicogodet see

QGIS/src/core/qgsgdalutils.cpp

Lines 860 to 903 in 31750d5

	QList<QgsGdalUtils::VsiNetworkFileSystemDetails> QgsGdalUtils::vsiNetworkFileSystems()
	{
	// get supported extensions
	static std::once_flag initialized;
	static QList<QgsGdalUtils::VsiNetworkFileSystemDetails> VSI_FILE_SYSTEM_DETAILS;
	std::call_once( initialized, [] {
	if ( char **papszPrefixes = VSIGetFileSystemsPrefixes() )
	{
	for ( int i = 0; papszPrefixes[i]; i++ )
	{
	QgsGdalUtils::VsiNetworkFileSystemDetails details;
	details.identifier = QString( papszPrefixes[i] );
	if ( details.identifier.startsWith( '/' ) )
	details.identifier = details.identifier.mid( 1 );
	if ( details.identifier.endsWith( '/' ) )
	details.identifier.chop( 1 );
	if ( details.identifier == "vsicurl"_L1 )
	details.name = QObject::tr( "HTTP/HTTPS/FTP" );
	else if ( details.identifier == "vsis3"_L1 )
	details.name = QObject::tr( "AWS S3" );
	else if ( details.identifier == "vsigs"_L1 )
	details.name = QObject::tr( "Google Cloud Storage" );
	else if ( details.identifier == "vsiaz"_L1 )
	details.name = QObject::tr( "Microsoft Azure Blob" );
	else if ( details.identifier == "vsiadls"_L1 )
	details.name = QObject::tr( "Microsoft Azure Data Lake Storage" );
	else if ( details.identifier == "vsioss"_L1 )
	details.name = QObject::tr( "Alibaba Cloud OSS" );
	else if ( details.identifier == "vsiswift"_L1 )
	details.name = QObject::tr( "OpenStack Swift Object Storage" );
	else if ( details.identifier == "vsihdfs"_L1 )
	details.name = QObject::tr( "Hadoop File System" );
	else
	continue;
	VSI_FILE_SYSTEM_DETAILS.append( details );
	}
	CSLDestroy( papszPrefixes );
	}
	} );
	return VSI_FILE_SYSTEM_DETAILS;
	}

introduced with #57826 since QGIS 3.40.

In particular this line:
protocolTypes += QgsProviderRegistry::instance()->protocolDrivers().split( ';' );
was removed from QgsOgrSourceSelect::QgsOgrSourceSelect

@nyalldawson , was it intended?

[agiudiceandrea]

@Roumagnifique, which QGIS version exactly are you using on Windows and which QGIS version exactly are you using on Ubuntu? Isn't directly using the Vector -> File with the URL to the GeoJSON file the same as is was using the Vector -> Protocol -> GeoJSON connection?

[Roumagnifique]

It was a partner who told me It was effective on Ubuntu. I think He used a QGIS version > 3.4.
On windows I use 3.40.7-Bratislava and the older version I showed in the printscreen is 3.16.0.

You are absolutely right! Putting the URL as a file instead of a protocol works very well!!! Thank you

[nyalldawson]

@nyalldawson I'm not following -- can you be more specific?

[agiudiceandrea]

I'm not following -- can you be more specific?

@nyalldawson,
in QGIS < 3.40 (before #57826) the Protocol type combo box (in QgsOgrSourceSelect) was filled with the types "HTTP/HTTPS/FTP, AWS S3, Google Cloud Storage, Microsoft Azure Blob, Microsoft Azure Data Lake Storage, Alibaba Cloud OSS, OpenStack Swift Object Storage, WFS3 (experimental)" and with the types returned by QgsProviderRegistry::instance()->protocolDrivers().split( ';' ) i.e. "GeoJSON, GeoJSON - Newline Delimited, FlatGeobuf" (and others, depending on the GDAL version/build).

in QGIS >= 3.40 (after #57826) the Protocol type combo box is also filled with the types "HTTP/HTTPS/FTP, AWS S3, ..., WFS3 (experimental)" but not with the types returned by QgsProviderRegistry::instance()->protocolDrivers().split( ';' ).

I wonder if it was intended or an oversight, since QgsGdalGuiUtils::createProtocolURI (which is only called inside QgsOgrSourceSelect based on the selected item of Protocol type combo box) still contains code to handle GeoJSON, GeoJSON - Newline Delimited and FlatGeobuf (and others) and QgsGdalGuiUtils::createProtocolURI was modified by #57826 but such code was not removed, although such types are no longer available in the combo box.