libindex: various lints

Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Change-Id: Ie36484d4b76a2dba60cebeb260c3c22e6a6a6964

Author: hdonnay

libindex/doc.go

@@ -0,0 +1,5 @@
+// Package libindex is the claircore Indexer.
+//
+// The Indexer is the component that analyzes container images (or
+// container-like filesystems) and produces IndexReports.
+package libindex

libindex/fetcher_test.go

@@ -231,18 +231,18 @@ func commonLayerServer(t testing.TB, ct int) ([]claircore.LayerDescription, http
 
 	t.Cleanup(func() {
 		// We know we're doing 2 sets of fetches.
-		max := ct * 2 * runtime.GOMAXPROCS(0)
+		limit := ct * 2 * runtime.GOMAXPROCS(0)
 		var total int
 		for _, v := range fetch {
 			total += int(*v)
 		}
 		switch {
-		case total > max:
-			t.Errorf("more fetches than should be possible: %d > %d", total, max)
-		case total == max:
-			t.Errorf("prevented no fetches: %d == %d", total, max)
-		case total < max:
-			t.Logf("prevented %[3]d fetches: %[1]d < %d", total, max, max-total)
+		case total > limit:
+			t.Errorf("more fetches than should be possible: %d > %d", total, limit)
+		case total == limit:
+			t.Errorf("prevented no fetches: %d == %d", total, limit)
+		case total < limit:
+			t.Logf("prevented %[3]d fetches: %[1]d < %d", total, limit, limit-total)
 		}
 	})
 	inner := http.FileServer(http.Dir(dir))

libindex/libindex.go

@@ -197,7 +197,7 @@ func (l *Libindex) Index(ctx context.Context, manifest *claircore.Manifest) (*cl
 //
 // If the identifier has changed, clients should arrange for layers to be
 // re-indexed.
-func (l *Libindex) State(ctx context.Context) (string, error) {
+func (l *Libindex) State(_ context.Context) (string, error) {
 	return l.state, nil
 }
 
@@ -207,7 +207,7 @@ func (l *Libindex) State(ctx context.Context) (string, error) {
 // Indexers running different scanner versions will produce different state strings.
 // Thus this state value can be used as a cue for clients to re-index their manifests
 // and obtain a new IndexReport.
-func (l *Libindex) setState(ctx context.Context, vscnrs indexer.VersionedScanners) error {
+func (l *Libindex) setState(_ context.Context, vscnrs indexer.VersionedScanners) error {
 	h := md5.New()
 	var ns []string
 	m := make(map[string][]byte)

libindex/libindex_integration_test.go

@@ -104,10 +104,14 @@ func (tc testcase) RunInner(ctx context.Context, t *testing.T, pool *pgxpool.Poo
 	}
 
 	// create libindex instance
+	a, err := CreateRemoteFetchArena(c, t.TempDir())
+	if err != nil {
+		t.Fatalf("failed to create RemoteFetchArena: %v", err)
+	}
 	opts := &Options{
 		Store:                store,
 		Locker:               ctxLocker,
-		FetchArena:           NewRemoteFetchArena(c, t.TempDir()),
+		FetchArena:           a,
 		ScanLockRetry:        2 * time.Second,
 		LayerScanConcurrency: 1,
 		Ecosystems: []*indexer.Ecosystem{
@@ -125,7 +129,7 @@ func (tc testcase) RunInner(ctx context.Context, t *testing.T, pool *pgxpool.Poo
 				RepositoryScanners: func(_ context.Context) ([]indexer.RepositoryScanner, error) {
 					return nil, nil
 				},
-				FileScanners: func(ctx context.Context) ([]indexer.FileScanner, error) {
+				FileScanners: func(_ context.Context) ([]indexer.FileScanner, error) {
 					return []indexer.FileScanner{&whiteout.Scanner{}}, nil
 				},
 				Coalescer: func(_ context.Context) (indexer.Coalescer, error) {

libindex/options.go

@@ -7,7 +7,11 @@ import (
 )
 
 const (
-	DefaultScanLockRetry        = 5 * time.Second
+	// DefaultScanLockRetry is the default time to wait between attempting to
+	// acquire the "scan lock".
+	DefaultScanLockRetry = 5 * time.Second
+	// DefaultLayerScanConcurrency is the default number of concurrent layer
+	// "scans".
 	DefaultLayerScanConcurrency = 10
 )