Skip to content

Commit 014d5dd

Browse files
committed
build: Ignore false positives from eslint-plugin-compat
1 parent 8c5967a commit 014d5dd

10 files changed

Lines changed: 25 additions & 23 deletions

File tree

.github/workflows/CI.yaml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ jobs:
4949
PUPPETEER_CACHE_DIR: "${{ github.workspace }}/.puppeteer_download"
5050
FORCE_COLOR: "1"
5151
steps:
52-
- uses: actions/checkout@v4
52+
- uses: actions/checkout@v6
5353

54-
- uses: actions/cache@v4
54+
- uses: actions/cache@v5
5555
if: ${{ runner.os != 'Windows' }}
5656
with:
5757
path: |
@@ -60,7 +60,7 @@ jobs:
6060
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}
6161

6262
- name: Use Node.js ${{ matrix.node }}
63-
uses: actions/setup-node@v4
63+
uses: actions/setup-node@v6
6464
with:
6565
node-version: ${{ matrix.node }}
6666

@@ -86,15 +86,15 @@ jobs:
8686
env:
8787
PUPPETEER_CACHE_DIR: "${{ github.workspace }}/.puppeteer_download"
8888
steps:
89-
- uses: actions/checkout@v4
90-
- uses: actions/cache@v4
89+
- uses: actions/checkout@v6
90+
- uses: actions/cache@v5
9191
with:
9292
path: |
9393
~/.npm
9494
${{ github.workspace }}/.puppeteer_download
9595
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}
9696
- name: Use Node.js 18
97-
uses: actions/setup-node@v4
97+
uses: actions/setup-node@v6
9898
with:
9999
node-version: 18.x
100100
- name: Install mozjs
@@ -124,15 +124,15 @@ jobs:
124124
env:
125125
PUPPETEER_CACHE_DIR: "${{ github.workspace }}/.puppeteer_download"
126126
steps:
127-
- uses: actions/checkout@v4
128-
- uses: actions/cache@v4
127+
- uses: actions/checkout@v6
128+
- uses: actions/cache@v5
129129
with:
130130
path: |
131131
~/.npm
132132
${{ github.workspace }}/.puppeteer_download
133133
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}
134134
- name: Use Node.js 18
135-
uses: actions/setup-node@v4
135+
uses: actions/setup-node@v6
136136
with:
137137
node-version: 18.x
138138
- name: Install mozjs

.github/workflows/browsers-full.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,17 @@ jobs:
1919
env:
2020
PUPPETEER_CACHE_DIR: "${{ github.workspace }}/.puppeteer_download"
2121
steps:
22-
- uses: actions/checkout@v4
22+
- uses: actions/checkout@v6
2323

24-
- uses: actions/cache@v4
24+
- uses: actions/cache@v5
2525
with:
2626
path: |
2727
~/.npm
2828
${{ github.workspace }}/.puppeteer_download
2929
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}
3030

3131
- name: Use Node.js 18
32-
uses: actions/setup-node@v4
32+
uses: actions/setup-node@v6
3333
with:
3434
node-version: 18.x
3535

.github/workflows/browsers-quick.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@ jobs:
1010
env:
1111
PUPPETEER_CACHE_DIR: "${{ github.workspace }}/.puppeteer_download"
1212
steps:
13-
- uses: actions/checkout@v4
13+
- uses: actions/checkout@v6
1414

15-
- uses: actions/cache@v4
15+
- uses: actions/cache@v5
1616
with:
1717
path: |
1818
~/.npm
1919
${{ github.workspace }}/.puppeteer_download
2020
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}
2121

2222
- name: Use Node.js 18
23-
uses: actions/setup-node@v4
23+
uses: actions/setup-node@v6
2424
with:
2525
node-version: 18.x
2626

.github/workflows/coverage.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,17 @@ jobs:
1111
PUPPETEER_CACHE_DIR: "${{ github.workspace }}/.puppeteer_download"
1212
FORCE_COLOR: "1"
1313
steps:
14-
- uses: actions/checkout@v4
14+
- uses: actions/checkout@v6
1515

16-
- uses: actions/cache@v4
16+
- uses: actions/cache@v5
1717
with:
1818
path: |
1919
~/.npm
2020
${{ github.workspace }}/.puppeteer_download
2121
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}
2222

2323
- name: Use Node.js 18
24-
uses: actions/setup-node@v4
24+
uses: actions/setup-node@v6
2525
with:
2626
node-version: 18.x
2727

.github/workflows/github-pages.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
DEPLOY_DIR: docs/_site/
1414
DEPLOY_BRANCH: gh-pages
1515
steps:
16-
- uses: actions/checkout@v4
16+
- uses: actions/checkout@v6
1717

1818
- name: Prepare branch
1919
run: |

.github/workflows/reproducible.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ jobs:
1212
if: ${{ github.repository == 'qunitjs/qunit' }} # skip noisy cron on forks
1313
runs-on: ubuntu-22.04
1414
steps:
15-
- uses: actions/checkout@v4
15+
- uses: actions/checkout@v6
1616

1717
- name: Use Node.js 18
18-
uses: actions/setup-node@v4
18+
uses: actions/setup-node@v6
1919
with:
2020
node-version: 18.x
2121

.github/workflows/spider-check.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
# - https://example.github.io/my-project/
2020
MY_SITE: https://qunitjs.com
2121
steps:
22-
- uses: actions/checkout@v4
22+
- uses: actions/checkout@v6
2323

2424
- name: Run hydra-link-checker
2525
run: |

.github/workflows/typesense.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
if: ${{ github.repository_owner == 'qunitjs' }} # skip on forks
1717
runs-on: ubuntu-latest
1818
steps:
19-
- uses: actions/checkout@v4
19+
- uses: actions/checkout@v6
2020
- name: Docsearch Scraper
2121
shell: bash
2222
run: |

src/core/dump.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,7 @@ export default (function () {
222222
keys.sort();
223223
for (let i = 0; i < keys.length; i++) {
224224
const key = keys[i];
225+
// eslint-disable-next-line compat/compat -- https://github.com/amilajack/eslint-plugin-compat/issues/688
225226
const val = map[key];
226227
ret.push(dump.parse(key, 'key') + ': '
227228
+ dump.parse(val, undefined, stack));

src/core/utilities.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export function diff (a, b) {
2323
* @return {boolean}
2424
*/
2525
export const inArray = Array.prototype.includes
26+
// eslint-disable-next-line compat/compat -- Checked
2627
? (elem, array) => array.includes(elem)
2728
: (elem, array) => array.indexOf(elem) !== -1;
2829

0 commit comments

Comments
 (0)