Skip to content

fix: add 'tabbar' to role type for accessibility#54512

Closed
hayleyyryan wants to merge 1 commit into
react:mainfrom
hayleyyryan:patch-tabbar-role
Closed

fix: add 'tabbar' to role type for accessibility#54512
hayleyyryan wants to merge 1 commit into
react:mainfrom
hayleyyryan:patch-tabbar-role

Conversation

@hayleyyryan

@hayleyyryan hayleyyryan commented Nov 12, 2025

Copy link
Copy Markdown

Summary:

The tabbar role was removed from AccessibilityRole in 2018 (commit f39d092) as it was only available on iOS 10+. It was later added back to AccessibilityRole once the minimum iOS version increased.

However, when the separate Role type was introduced in 2022 for the role prop, tabbar was not included despite being present in AccessibilityRole. This inconsistency causes TypeScript compilation errors when trying to use role="tabbar" on components, even though it's a valid and working accessibility role that exists in AccessibilityRole.

This PR adds tabbar to the Role type definition to maintain consistency between AccessibilityRole and Role, allowing developers to use this role without TypeScript errors and for accurate announcements for screen reader users.

Changelog:

Test Plan:

Before this change, the following TypeScript code would fail compilation:

<View role="tabbar">
  {/* ... */}
</View>

After this change, the code compiles successfully. The tabbar role also already exists in AccessibilityRole (line 213 of ViewAccessibility.d.ts) and works correctly at runtime on all currently supported iOS versions.

@meta-cla

meta-cla Bot commented Nov 12, 2025

Copy link
Copy Markdown

Hi @hayleyyryan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Nov 12, 2025

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2025
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 12, 2025
@react-native-bot

Copy link
Copy Markdown
Collaborator

This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label.

@react-native-bot react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label May 12, 2026

@popsiclelmlm popsiclelmlm left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks directionally right, but I think it needs a couple more files before it can land cleanly.

role is typed in more than the hand-written ViewAccessibility.d.ts file:

  • packages/react-native/Libraries/Components/View/ViewAccessibility.js has the Flow Role union for the JS source, and it currently still has tab -> table without tabbar.
  • packages/react-native/ReactNativeApi.d.ts is the generated public API snapshot, and its Role union also still lacks "tabbar".

So this PR should update the Flow source type and run yarn build-types / yarn build-types --validate so the API snapshot is updated too. Otherwise TypeScript users may be fixed in one declaration file, but the checked public API surface will still be out of sync.

Also, the changelog entry appears to be inside the template HTML comment. It should be outside the comment block, e.g. [IOS] [FIXED] - Add tabbar to the role type for accessibility.

@cortinico

Copy link
Copy Markdown
Contributor

@cortinico cortinico closed this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Stale There has been a lack of activity on this issue and it may be closed soon.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants