Updated Rector to commit badcffc946057eac210b7bd3c16a4c952721b9be

rectorphp/rector-src@badcffc [Arguments] Skip self class const fetch inside this class target replacement on ReplaceArgumentDefaultValueRector (#7940)

Author: TomasVotruba

rules/Arguments/ArgumentDefaultValueReplacer.php

@@ -12,13 +12,17 @@
 use PhpParser\Node\Expr\New_;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Variable;
+use PhpParser\Node\Identifier;
+use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\ClassMethod;
 use Rector\Arguments\Contract\ReplaceArgumentDefaultValueInterface;
 use Rector\Arguments\ValueObject\ReplaceArgumentDefaultValue;
 use Rector\NodeAnalyzer\ArgsAnalyzer;
+use Rector\NodeTypeResolver\NodeTypeResolver;
 use Rector\PhpParser\AstResolver;
 use Rector\PhpParser\Node\NodeFactory;
 use Rector\PhpParser\Node\Value\ValueResolver;
+use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType;
 final class ArgumentDefaultValueReplacer
 {
     /**
@@ -37,12 +41,17 @@ final class ArgumentDefaultValueReplacer
      * @readonly
      */
     private AstResolver $astResolver;
-    public function __construct(NodeFactory $nodeFactory, ValueResolver $valueResolver, ArgsAnalyzer $argsAnalyzer, AstResolver $astResolver)
+    /**
+     * @readonly
+     */
+    private NodeTypeResolver $nodeTypeResolver;
+    public function __construct(NodeFactory $nodeFactory, ValueResolver $valueResolver, ArgsAnalyzer $argsAnalyzer, AstResolver $astResolver, NodeTypeResolver $nodeTypeResolver)
     {
         $this->nodeFactory = $nodeFactory;
         $this->valueResolver = $valueResolver;
         $this->argsAnalyzer = $argsAnalyzer;
         $this->astResolver = $astResolver;
+        $this->nodeTypeResolver = $nodeTypeResolver;
     }
     /**
      * @template TCall as (MethodCall|StaticCall|ClassMethod|FuncCall|New_)
@@ -139,7 +148,15 @@ private function processArgs($expr, ReplaceArgumentDefaultValueInterface $replac
         }
         $argValue = $this->valueResolver->getValue($particularArg->value);
         if (is_scalar($replaceArgumentDefaultValue->getValueBefore()) && $argValue === $replaceArgumentDefaultValue->getValueBefore()) {
-            $particularArg->value = $this->normalizeValue($replaceArgumentDefaultValue->getValueAfter());
+            $normalizedValueAfter = $this->normalizeValue($replaceArgumentDefaultValue->getValueAfter());
+            if ($particularArg->value instanceof ClassConstFetch && $particularArg->value->class instanceof Name && $particularArg->value->class->isSpecialClassName() && $normalizedValueAfter instanceof ClassConstFetch && is_string($replaceArgumentDefaultValue->getValueAfter()) && strpos($replaceArgumentDefaultValue->getValueAfter(), '::') !== \false) {
+                [$targetClass, $targetConstant] = explode('::', $replaceArgumentDefaultValue->getValueAfter());
+                $type = $this->nodeTypeResolver->getType($particularArg->value->class);
+                if ($type instanceof FullyQualifiedObjectType && $type->getClassName() === $targetClass && $particularArg->value->name instanceof Identifier && $particularArg->value->name->toString() === $targetConstant) {
+                    return null;
+                }
+            }
+            $particularArg->value = $normalizedValueAfter;
             return $expr;
         }
         if (is_array($replaceArgumentDefaultValue->getValueBefore())) {

src/Application/VersionResolver.php

@@ -19,12 +19,12 @@ final class VersionResolver
      * @api
      * @var string
      */
-    public const PACKAGE_VERSION = 'd9133842a6df2ed3141cad1b5043a7a567165045';
+    public const PACKAGE_VERSION = 'badcffc946057eac210b7bd3c16a4c952721b9be';
     /**
      * @api
      * @var string
      */
-    public const RELEASE_DATE = '2026-03-27 12:04:47';
+    public const RELEASE_DATE = '2026-03-28 15:09:27';
     /**
      * @var int
      */

src/Caching/Config/FileHashComputer.php

@@ -34,8 +34,8 @@ public function compute(string $filePath): string
     private function computeExtensionHash(): string
     {
         $extensionHash = '';
-        foreach ($this->cacheMetaExtensions as $cacheMetaExtension) {
-            $extensionHash .= $cacheMetaExtension->getKey() . ':' . $cacheMetaExtension->getHash();
+        foreach ($this->cacheMetaExtensions as $cacheMetumExtension) {
+            $extensionHash .= $cacheMetumExtension->getKey() . ':' . $cacheMetumExtension->getHash();
         }
         return $extensionHash;
     }

src/Configuration/RectorConfigBuilder.php

@@ -227,8 +227,8 @@ public function __invoke(RectorConfig $rectorConfig): void
         if ($this->containerCacheDirectory !== null) {
             $rectorConfig->containerCacheDirectory($this->containerCacheDirectory);
         }
-        foreach ($this->cacheMetaExtensions as $cacheMetaExtensionClass) {
-            $rectorConfig->cacheMetaExtension($cacheMetaExtensionClass);
+        foreach ($this->cacheMetaExtensions as $cacheMetumExtension) {
+            $rectorConfig->cacheMetaExtension($cacheMetumExtension);
         }
         if ($this->importNames || $this->importDocBlockNames) {
             $rectorConfig->importNames($this->importNames, $this->importDocBlockNames);