BlockList in BlockGrid

[mg-pl]

Which Umbraco.Community.BlockPreview version are you using?

5.3.2

Which Umbraco version are you using? For example: 10.4.0 - don't just write v10

17.1

Bug summary

Content pickers in elements used in BlockList which is part of element used in BlockGrid, return null.

Steps to reproduce

1. Create two elements: Parent and Child.
2. Add content picker to Child.
3. Create BlockList with Child as available block
4. Add newly created BlockList as property to Parent
5. Create BlockGrid with Parent as available block
6. Add newly created BlockGrid to document, pick some content, create template for preview etc.

Website I'm working on has multiple languages.

Expected result / actual result

Content picker crated in 2) returns picked IPublishedContent instead of null.

This worked in 5.2.1

[deanleigh]

Hi @mg-pl
I don't know if this helps but I do have some examples of using Blocklist inside block in my demonstration package

https://umbootstrap.com/features/feature-faqs/

[mg-pl]

@deanleigh

https://umbootstrap.com/features/feature-faqs/

I added a content picker to featureComponentFAQ. Initially it seemed to work, but then things went downhill.
I replaced the default picker with a custom one configured with:

• Min items: 0
• Max items: 1
• Allowed type: Web Page

After making this change, the property began returning null. Since then, I haven't been able to get it working again, even after switching back to the standard content picker.

[russellshome]

I've created a basic example to demonstrate this bug
https://github.com/russellshome/UmbracoTestSite
Login: admin@admin.com
Pass: admin@admin.com

[russellshome]

I have also found the same issue with BlockGrid within BlockGrid

[russellshome]

I think I may have tracked down the cause of the issue.

In line 206 of BlockPreviewService a converson is invoked

BlockPreview/src/Umbraco.Community.BlockPreview/Services/BlockPreviewService.cs

Line 206 in e0a57ea

_blockDataConverter.FormatBlockData(blockValue?.BlockValue.ContentData);

Eventually that gets to line 231 of BlockDataConverter

BlockPreview/src/Umbraco.Community.BlockPreview/Services/BlockDataConverter.cs

Line 231 in e0a57ea

propertyData.Value = valueEditor.FromEditor(editorValue, null);

Looking in the Umbraco code at what happens there:
https://github.com/umbraco/Umbraco-CMS/blob/ea3b0d4d59db453da6b068b1016619a78df0a7d3/src/Umbraco.Core/PropertyEditors/ContentPickerPropertyEditor.cs#L102

So the value of a content picker which is stored as a plain GUID is converted to a GuidUdi

Later in the same function in BlockPreviewService

BlockPreview/src/Umbraco.Community.BlockPreview/Services/BlockPreviewService.cs

Line 213 in e0a57ea

IPublishedElement contentElement = _blockDataConverter.ConvertToElement(contentData, content);

The function ConvertToElement is called on the already converted data

BlockPreview/src/Umbraco.Community.BlockPreview/Services/BlockDataConverter.cs

Line 91 in e0a57ea

public IPublishedElement ConvertToElement(BlockItemData data, IPublishedElement owner)

When that gets back to line 231 of BlockDataConverter in the case of a content picker it passes though the value which is now a GuidUdi and since Umbraco doesn't recognise that value it returns null.

I commented out the block
if (data != null)
{
....
}
In

BlockPreview/src/Umbraco.Community.BlockPreview/Services/BlockDataConverter.cs

Line 91 in e0a57ea

public IPublishedElement ConvertToElement(BlockItemData data, IPublishedElement owner)

And that seems to fix the issue.

============

However, I don't know why the function ConvertToElement includes what appears to be a partial duplicate of the code in FormatBlockData so commenting it out might affect something else?