Consider usage of new KeyboardEvent

[rheone]

Seems that event.which is no longer the way to pick up on key presses.

KeyboardEvent seems to be the way things are done with modern browsers.

We need to consider the new hotness that is KeyboardEvent.key and the related Key Values that will need to be the replacement of privateScanCodeMap

Be aware that making this change will limit our backwards compatibility can I use: keyboardevent.key

@ahsteele pointed out w3c-keys
which has a TypeScript definitions for many (but I don't think all) of the keys.

[ahsteele]

I think the browser support is good enough that we will be fine. Even with the partial support from IE11.

…

On Sun, Oct 27, 2019 at 9:51 AM Robert Engelhardt ***@***.***> wrote: Seems that event.which is no longer *the way* to pick up on key presses. KeyboardEvent <https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent> seems to be the way things are done with modern browsers. We need to consider the new hotness that is KeyboardEvent.key <https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key> and the related Key Values <https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key/Key_Values> that will need to be the replacement of privateScanCodeMap Be aware that making this change will limit our backwards compatibility can I use: keyboardevent.key <https://caniuse.com/#feat=keyboardevent-key> @ahsteele <https://github.com/ahsteele> pointed out w3c-keys <https://github.com/ashubham/w3c-keys> which has a TypeScript definitions for many (but I don't think all) of the keys. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11?email_source=notifications&email_token=AADIVSZDKUYD5FNYFJQNOZDQQW2GPA5CNFSM4JFSIATKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUTQPHA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADIVS4QD2MJGIWJB7DUFKLQQW2GPANCNFSM4JFSIATA> .