few more improvements

Author: santisq

src/ADEffectiveAccess/DirectoryEntryBuilder.cs

@@ -12,8 +12,6 @@ internal sealed class DirectoryEntryBuilder : IDisposable
 
     private readonly AuthenticationTypes _authenticationTypes;
 
-    // internal DirectoryEntry RootDSE { get; }
-
     internal DirectoryEntry RootEntry { get; }
 
     internal DirectoryEntry SearchBase { get; }
@@ -29,9 +27,7 @@ internal DirectoryEntryBuilder(
         _username = credential?.UserName;
         _password = credential?.GetNetworkCredential().Password;
         _authenticationTypes = authenticationTypes;
-        // RootDSE = Create(server is null ? "RootDSE" : $"{server}/RootDSE");
         RootEntry = Create(server: server);
-        // Root = RootEntry.Properties["distinguishedName"][0]?.ToString();
         SearchBase = Create(searchBase: searchBase);
     }
 
@@ -48,15 +44,10 @@ internal DirectoryEntry Create(string? server = null, string? searchBase = null)
         return new(path, _username, _password, _authenticationTypes);
     }
 
-    // internal string GetRootProperty(string property) =>
-    //     RootDSE.Properties[property][0]?.ToString()
-    //         ?? throw RootDSE.ToInitializeResolverException(property);
-
     public void Dispose()
     {
         RootEntry.Dispose();
         SearchBase.Dispose();
-        // RootDSE.Dispose();
         GC.SuppressFinalize(this);
     }
 }

src/ADEffectiveAccess/Extensions.cs

@@ -1,10 +1,12 @@
 using System;
-using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using System.DirectoryServices;
 using System.Management.Automation;
 using System.Security.Principal;
 using System.Text;
+#if !NETCOREAPP
+using System.Collections.Generic;
+#endif
 
 namespace ADEffectiveAccess;
 

src/ADEffectiveAccess/GetADEffectiveAccessComand.cs

@@ -169,12 +169,6 @@ _ when LanguagePrimitives.TryConvertTo(identity, out SecurityIdentifier sid) =>
         SearchResult result = searcher.FindOne()
             ?? throw identity.ToIdentityNotFoundException(builder.Root);
 
-        if (!result.TryGetProperty(SecurityDescriptor, out byte[]? descriptor))
-        {
-            result.WriteInvalidSecurityDescriptorError(this);
-            return;
-        }
-
         WriteRules(result);
     }
 

src/ADEffectiveAccess/GuidResolver.cs

@@ -25,15 +25,15 @@ private GuidResolver() { }
     internal void SetContext(string? server, DirectoryEntryBuilder builder)
     {
         using DirectoryEntry rootDSE = builder.Create(server, "RootDSE");
-        string ctxName = rootDSE.GetRootProperty(DefaultContext);
+        string context = rootDSE.GetRootProperty(DefaultContext);
 
-        if (_map.TryGetValue(ctxName, out Dictionary<Guid, string>? current))
+        if (_map.TryGetValue(context, out Dictionary<Guid, string>? current))
         {
             _current = current;
             return;
         }
 
-        _current = _map[ctxName] = [];
+        _current = _map[context] = [];
         string schemaNamingContext = rootDSE.GetRootProperty(SchemaContext);
         string extendedRights = $"CN=Extended-Rights,{rootDSE.GetRootProperty(ConfigurationContext)}";
 

src/ADEffectiveAccess/RunspaceSpecificStorage.cs

@@ -7,12 +7,12 @@ namespace ADEffectiveAccess;
 
 internal sealed class RunspaceSpecificStorage<T>(Func<T> factory)
 {
-    internal readonly ConditionalWeakTable<Runspace, Lazy<T>> _map = new();
-
     private readonly Func<T> _factory = factory;
 
     private readonly LazyThreadSafetyMode _mode = LazyThreadSafetyMode.ExecutionAndPublication;
 
+    internal readonly ConditionalWeakTable<Runspace, Lazy<T>> _map = new();
+
     internal T GetFromTLS() => GetForRunspace(Runspace.DefaultRunspace);
 
     internal T GetForRunspace(Runspace runspace)