some more ci/cd fixes

Author: saru2020

.github/workflows/deploy-pipeline.yml

@@ -196,30 +196,35 @@ jobs:
           # Get outputs from Terraform
           echo "Getting infrastructure outputs..."
           
-          # Capture Terraform outputs with better error handling
+          # Capture Terraform outputs by writing to files first
           echo "Capturing S3 bucket name..."
-          S3_BUCKET_NAME=$(terraform output -raw s3_bucket_name 2>&1)
-          if [ $? -ne 0 ]; then
-            echo "⚠️  Failed to get S3 bucket name from Terraform, using default"
+          terraform output -raw s3_bucket_name > s3_bucket_name.txt 2>/dev/null || echo "ml-crash-course-data" > s3_bucket_name.txt
+          S3_BUCKET_NAME=$(cat s3_bucket_name.txt | tr -d '\n\r')
+          
+          echo "Capturing EKS cluster name..."
+          terraform output -raw eks_cluster_name > eks_cluster_name.txt 2>/dev/null || echo "ml-crash-course-cluster" > eks_cluster_name.txt
+          EKS_CLUSTER_NAME=$(cat eks_cluster_name.txt | tr -d '\n\r')
+          
+          # Fallback to known values if extraction failed
+          if [ -z "$S3_BUCKET_NAME" ] || [ "$S3_BUCKET_NAME" = "" ]; then
             S3_BUCKET_NAME="ml-crash-course-data"
           fi
           
-          echo "Capturing EKS cluster name..."
-          EKS_CLUSTER_NAME=$(terraform output -raw eks_cluster_name 2>&1)
-          if [ $? -ne 0 ]; then
-            echo "⚠️  Failed to get EKS cluster name from Terraform, using default"
+          if [ -z "$EKS_CLUSTER_NAME" ] || [ "$EKS_CLUSTER_NAME" = "" ]; then
             EKS_CLUSTER_NAME="ml-crash-course-cluster"
           fi
           
-          # Clean up any extra output from the commands
-          S3_BUCKET_NAME=$(echo "$S3_BUCKET_NAME" | head -n1 | tr -d '\n\r')
-          EKS_CLUSTER_NAME=$(echo "$EKS_CLUSTER_NAME" | head -n1 | tr -d '\n\r')
-          
           echo "s3_bucket_name=$S3_BUCKET_NAME" >> $GITHUB_OUTPUT
           echo "eks_cluster_name=$EKS_CLUSTER_NAME" >> $GITHUB_OUTPUT
           echo "Using S3 Bucket: $S3_BUCKET_NAME"
           echo "Using EKS Cluster: $EKS_CLUSTER_NAME"
           
+          # Debug: Show the actual values
+          echo "🔍 Debug - S3 Bucket Name: '$S3_BUCKET_NAME'"
+          echo "🔍 Debug - EKS Cluster Name: '$EKS_CLUSTER_NAME'"
+          echo "🔍 Debug - S3 Bucket Name length: ${#S3_BUCKET_NAME}"
+          echo "🔍 Debug - EKS Cluster Name length: ${#EKS_CLUSTER_NAME}"
+          
           # Wait for EKS cluster to be ready
           echo "⏳ Waiting for EKS cluster to be ready..."
           aws eks wait cluster-active --name "$EKS_CLUSTER_NAME" --region ${{ secrets.AWS_REGION }}