Skip to content

Commit 7a8b86f

Browse files
authored
fix: update build tools and fix arm64 build for rpi (#111)
Two problems to fix with this one - our rpi arm64 isn't working possibly because our libc is too new, so we'll target the lts of arm64, worked for [level](Level/classic-level#71) thankful for [their investigation](Level/classic-level#69) - our arm64 builds were just broken and wouldn't build so we're fixing that with a variable in our binding.gyp for `openssl_fips` When this is released it will hopefully fix serialport/node-serialport#2438
1 parent 21500b6 commit 7a8b86f

File tree

4 files changed

+29
-26
lines changed

4 files changed

+29
-26
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
- name: linux-arm
3333
os: ubuntu-latest
3434
command: prebuildify-cross
35-
args: -i linux-arm64 -i linux-armv7 -i linux-armv6
35+
args: -i linux-arm64-lts -i linux-armv7 -i linux-armv6
3636
- name: android-arm
3737
os: ubuntu-latest
3838
command: prebuildify-cross

binding.gyp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
{
2+
'variables': {
3+
'openssl_fips': ''
4+
},
25
'targets': [{
36
'target_name': 'bindings',
47
'sources': [

package-lock.json

Lines changed: 22 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
"@serialport/bindings-interface": "1.2.2",
2222
"@serialport/parser-readline": "^10.2.1",
2323
"debug": "^4.3.2",
24-
"node-addon-api": "^5.0.0",
25-
"node-gyp-build": "^4.3.0"
24+
"node-addon-api": "6.0.0",
25+
"node-gyp-build": "4.6.0"
2626
},
2727
"devDependencies": {
2828
"@semantic-release/exec": "6.0.3",
@@ -42,7 +42,7 @@
4242
"eslint": "8.38.0",
4343
"mocha": "10.2.0",
4444
"node-abi": "3.40.0",
45-
"node-gyp": "9.3.0",
45+
"node-gyp": "9.3.1",
4646
"nyc": "15.1.0",
4747
"prebuildify": "5.0.1",
4848
"prebuildify-cross": "5.0.0",

0 commit comments

Comments
 (0)