Change SQLiteError.onInternalError to include inner error instead of String (#31)

Author: atdrendel

README.md

@@ -17,7 +17,7 @@ To use SQLite with the Swift Package Manager, add a dependency to your Package.s
 ```swift
 let package = Package(
   dependencies: [
-    .package(url: "https://github.com/shareup/sqlite.git", .upToNextMajor(from: "15.0.0"))
+    .package(url: "https://github.com/shareup/sqlite.git", .upToNextMajor(from: "16.0.0"))
   ]
 )
 ```

Sources/SQLite/SQLiteDatabase.swift

@@ -123,7 +123,7 @@ extension SQLiteDatabase {
                 } catch let error as SQLiteError {
                     promise(.failure(error))
                 } catch {
-                    promise(.failure(.onInternalError(error.localizedDescription)))
+                    promise(.failure(.onInternalError(error as NSError)))
                 }
             }
         }
@@ -153,7 +153,7 @@ extension SQLiteDatabase {
             if let sqliteError = error as? SQLiteError {
                 return sqliteError
             } else {
-                return .onInternalError(error.localizedDescription)
+                return .onInternalError(error as NSError)
             }
         }
         .eraseToAnyPublisher()
@@ -187,7 +187,7 @@ extension SQLiteDatabase {
                 if let sqliteError = error as? SQLiteError {
                     return sqliteError
                 } else {
-                    return .onInternalError(error.localizedDescription)
+                    return .onInternalError(error as NSError)
                 }
             }
             .eraseToAnyPublisher()
@@ -510,7 +510,7 @@ extension SQLiteDatabase {
                 } catch let error as SQLiteError {
                     promise(.failure(error))
                 } catch {
-                    promise(.failure(.onInternalError(error.localizedDescription)))
+                    promise(.failure(.onInternalError(error as NSError)))
                 }
             }
         }

Sources/SQLite/SQLiteError.swift

@@ -3,7 +3,7 @@ import SQLite3
 
 public enum SQLiteError: Error, Equatable {
     case databaseIsClosed
-    case onInternalError(String)
+    case onInternalError(NSError)
     case onInvalidPath(String)
     case onOpenSharedDatabase(String, String)
     case onOpen(Int32, String)
@@ -106,7 +106,7 @@ extension SQLiteError: CustomStringConvertible {
         case .databaseIsClosed:
             return "Database is closed"
         case .onInternalError(let error):
-            return "Internal error: '\(error)'"
+            return "Internal error: '\(String(describing: error))'"
         case .onInvalidPath(let path):
             return "Invalid path: '\(path)'"
         case .onOpenSharedDatabase(let path, let error):

Sources/SQLite/SQLiteResultsPublisher.swift

@@ -185,8 +185,7 @@ private final class SQLiteStatementResultsSubscription<S>: Subscription, Subscri
                     state.cancel()
                     return {
                         subscription.cancel()
-                        let errorStr = String(describing: error)
-                        sub.receive(completion: .failure(.onInternalError(errorStr)))
+                        sub.receive(completion: .failure(.onInternalError(error as NSError)))
                     }
                 }
 
@@ -252,9 +251,8 @@ private final class SQLiteStatementResultsSubscription<S>: Subscription, Subscri
                     subscriber = nil
                     state.cancel()
                     return {
-                        let err = String(describing: error)
                         subscription.cancel()
-                        sub.receive(completion: .failure(.onInternalError(err)))
+                        sub.receive(completion: .failure(.onInternalError(error as NSError)))
                     }
                 }
             }