feat: add golangci-lint config and fix lint issues

Author: singl3focus

.gitignore

@@ -6,6 +6,11 @@
 *.dylib
 *.test
 *.out
+.cache/
+.gocache/
+
+# Test artifacts
+reports/
 
 # Common Go outputs
 /bin/

.golangci.yml

@@ -0,0 +1,39 @@
+version: "2"
+
+run:
+  timeout: "5m"
+  tests: true
+
+linters:
+  enable:
+    - govet
+    - errcheck
+    - staticcheck
+    - unused
+    - ineffassign
+    - whitespace
+    - gocyclo
+
+formatters:
+  enable:
+    - gofmt
+    - gci
+  settings:
+    gci:
+      sections:
+        - standard
+        - default
+        - localmodule
+
+issues:
+  new: false
+  fix: true
+
+output: 
+  show-stats: true
+  formats:
+    text:
+      path: reports/linters-out.txt
+      print-linter-name: true
+      print-issued-lines: true
+      colors: true

internal/config/config.go

@@ -7,8 +7,9 @@ import (
 	"path/filepath"
 	"strings"
 
-	"github.com/singl3focus/pmp/internal/block"
 	"gopkg.in/yaml.v3"
+
+	"github.com/singl3focus/pmp/internal/block"
 )
 
 var ErrConfigNotFound = errors.New("no pmp config found; run `pmp init` or `pmp init --global`")
@@ -198,18 +199,21 @@ func discoverProjectRoot(start string) (string, error) {
 	}
 }
 
-func loadFile(path string) (fileConfig, error) {
+func loadFile(path string) (cfg fileConfig, err error) {
 	file, err := os.Open(path)
 	if err != nil {
 		return fileConfig{}, fmt.Errorf("read config %s: %w", path, err)
 	}
-	defer file.Close()
+	defer func() {
+		if closeErr := file.Close(); err == nil && closeErr != nil {
+			err = fmt.Errorf("close config %s: %w", path, closeErr)
+		}
+	}()
 
-	var cfg fileConfig
 	dec := yaml.NewDecoder(file)
 	dec.KnownFields(true)
-	if err := dec.Decode(&cfg); err != nil {
-		return fileConfig{}, fmt.Errorf("parse config %s: %w", path, err)
+	if decodeErr := dec.Decode(&cfg); decodeErr != nil {
+		return fileConfig{}, fmt.Errorf("parse config %s: %w", path, decodeErr)
 	}
 	if cfg.MessagePosition != "" &&
 		cfg.MessagePosition != MessagePositionTop &&

internal/engine/engine.go

@@ -8,9 +8,10 @@ import (
 	"text/template"
 	"time"
 
+	"github.com/tiktoken-go/tokenizer"
+
 	"github.com/singl3focus/pmp/internal/block"
 	"github.com/singl3focus/pmp/internal/config"
-	"github.com/tiktoken-go/tokenizer"
 )
 
 type BuildRequest struct {