Skip to content

Commit 5afb957

Browse files
skerkerclaude
andcommitted
docs(logging): record why no blanket Info off-rule accompanies the toggle (aethersdr#4588 review)
Folds the asymmetry note into applyFilterRules()'s comment, per review: no blanket aether.*.info=false is emitted — it would newly silence the QtDebugMsg/QtInfoMsg-declared categories whose Info is visible today — so for those categories the toggle governs Debug only. Comment-only change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent cdc6892 commit 5afb957

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

src/core/LogManager.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,12 @@ void LogManager::applyFilterRules()
172172
// never once appeared in a log file. Neither had the 16 qCInfo
173173
// calls on lcDax. Two dozen categories are declared QtWarningMsg,
174174
// so this was most of the codebase's INFO logging.
175+
//
176+
// Note the asymmetry: no blanket "aether.*.info=false" is emitted
177+
// above — it would newly silence the QtDebugMsg/QtInfoMsg-declared
178+
// categories (aether.kiwisdr, aether.connection, aether.hl2, …)
179+
// whose Info is visible today. For those, this toggle governs
180+
// Debug only; their Info stays on regardless.
175181
rules << QString("%1.info=true").arg(c.id);
176182
}
177183
}

0 commit comments

Comments
 (0)