Spec: Correct tcpListener/tcpConnector required fields

[c-kruse]

What

In skrouter.json the tcpListener and tcpConnector entity specs have their address and port attributes specified without "required": true, but the C implementation uses qd_entity_get_string for these indicating they are required by the implementation.

Inconsistencies like this make it difficult to generate go type definitions based off of the entity spec, and also causes operations with missing attributes to fall back on validations in C instead of in the initial python layer.

# required=false
[christian@toolbx skupper-router] (main)$ skmanage create --type tcpListener --name tl01 observer=auto
InternalServerErrorStatus: CError: Python: KeyError: 'port'
# required=true
[christian@toolbx skupper-router] (main *)$ skmanage create --type tcpListener --name tl01 observer=auto
BadRequestStatus: Missing required attribute 'port'

Suggestion

Explicitly mark these attributes as required in the spec.

A step further would be to purge all of the usages of "required": false from the spec in order to avoid confusion over the default required-ness of attributes. It is my best guess that confusing this was a contributing factor to this misconfiguration.

[ted-ross]

Agree that the listed attributes (or anywhere the C code assumes the attribute is present) must be annotated as required: true.

Further agree that either we remove the "required: false" attributes from the spec or we make the "required" attribute required.

[c-kruse]

Actually, @ted-ross @gabordozsa - do we want to make tcpListener address optional with the listenerAddress changes?

[gabordozsa]

Actually, @ted-ross @gabordozsa - do we want to make tcpListener address optional with the listenerAddress changes?

I think that would make sense. Exactly one of the address or the multiAddressSrategy should be defined. We can have both optional in the schema and modify the C code to check and reject if both or none of them are defined.