Use curl for Chocolatey asset download

Keith · Keith · commit 5c7aa4e806b5 · 2026-07-08T09:49:46.000-06:00
diff --git a/.council/active-bughunt.md b/.council/active-bughunt.md
diff --git a/.council/latest-candidate-counts.md b/.council/latest-candidate-counts.md
diff --git a/.github/workflows/publish-chocolatey.yml b/.github/workflows/publish-chocolatey.yml
@@ -38,21 +38,28 @@ jobs:
       - name: Download Windows release asset
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        shell: pwsh
+        shell: bash
         run: |
-          $ErrorActionPreference = "Stop"
-          $Asset = "iptv-tunerr-${{ inputs.version }}-windows-amd64.zip"
-          $DownloadDir = Join-Path $env:RUNNER_TEMP "chocolatey-assets"
-          New-Item -ItemType Directory -Force -Path $DownloadDir | Out-Null
-          Remove-Item -Force -ErrorAction SilentlyContinue (Join-Path $DownloadDir $Asset)
-          gh release download "${{ inputs.version }}" `
-            --repo "${{ github.repository }}" `
-            --pattern $Asset `
-            --dir $DownloadDir `
-            --clobber
-          if (-not (Test-Path (Join-Path $DownloadDir $Asset))) {
-            throw "Expected release asset was not downloaded: $Asset"
-          }
+          set -euo pipefail
+          asset="iptv-tunerr-${{ inputs.version }}-windows-amd64.zip"
+          download_dir="${RUNNER_TEMP}/chocolatey-assets"
+          mkdir -p "${download_dir}"
+          rm -f "${download_dir}/${asset}"
+          url="https://github.com/${{ github.repository }}/releases/download/${{ inputs.version }}/${asset}"
+          auth_header=()
+          if [[ -n "${GH_TOKEN:-}" ]]; then
+            auth_header=(-H "Authorization: Bearer ${GH_TOKEN}")
+          fi
+          curl --fail --location --show-error --silent \
+            --connect-timeout 20 \
+            --max-time 180 \
+            --retry 3 \
+            --retry-all-errors \
+            --retry-delay 2 \
+            --output "${download_dir}/${asset}" \
+            "${auth_header[@]}" \
+            "${url}"
+          test -s "${download_dir}/${asset}"
 
       - name: Pack and push
         env:
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -14,7 +14,7 @@ All notable changes to IPTV Tunerr are documented here. Repo: [github.com/snapet
 ## [Unreleased]
 
 ### CI / Packaging
-- **Chocolatey metadata now covers moderation feedback:** the Chocolatey package template and publish workflow now set package owner, icon, package source, project source, docs, bug tracker, and release notes metadata, the install script points the explicit shim at the nested Windows executable path used by release ZIPs, and publishing now packs/pushes with .NET installed under runner temp on the existing Linux runner pool instead of waiting for an unavailable Windows runner. The Windows ZIP download also uses a runner-temp asset directory with `--clobber` so reused self-hosted workspaces cannot stall the publish.
+- **Chocolatey metadata now covers moderation feedback:** the Chocolatey package template and publish workflow now set package owner, icon, package source, project source, docs, bug tracker, and release notes metadata, the install script points the explicit shim at the nested Windows executable path used by release ZIPs, and publishing now packs/pushes with .NET installed under runner temp on the existing Linux runner pool instead of waiting for an unavailable Windows runner. The Windows ZIP download also uses a runner-temp asset directory plus timeout-bounded `curl` retries so reused self-hosted workspaces cannot stall the publish.
 - **COPR publishing now attempts configured fallback auth after token expiry:** the COPR workflow prepares Fedora GSSAPI fallback credentials even when token credentials are present, then retries COPR CLI calls with that fallback when COPR rejects the token as invalid or expired. The `v0.1.85` COPR channel was restored by rotating the API token; the fallback remains available for future token-expiry recovery.
 - **COPR SRPM publishing now uses the requested release version:** the COPR workflow builds SRPMs in an isolated temporary RPM topdir, copies the expected `iptvtunerr-${version}-1.src.rpm` into a relative `dist/` path, and uploads that explicit file instead of reusing persistent `~/rpmbuild` state on the self-hosted runner.
 
diff --git a/memory-bank/current_task.md b/memory-bank/current_task.md
@@ -6,10 +6,10 @@
 - Done: patched the Chocolatey nuspec/template metadata, added a controlled package icon asset, corrected the explicit Windows shim target, and made the publish workflow rewrite nuspec/install-script content before packing so existing release tags can be republished without moving tags.
 - Done: after the first dispatch queued indefinitely because no online runner had the old `Windows` label, changed Chocolatey publishing to run on the repo Linux runner pool and pack/push with .NET/NuGet.
 - Done: after the first Linux dispatch failed because setup-dotnet tried to write `/usr/share/dotnet` without permission, constrained the .NET install directory to runner temp.
-- Done: after the next Linux dispatch hung while downloading the release ZIP in a reused self-hosted workspace, made the asset download noninteractive by placing it under runner temp with `--clobber` and hashing that explicit path.
+- Done: after the next Linux dispatch hung while downloading the release ZIP in a reused self-hosted workspace, moved the asset download under runner temp and replaced `gh release download` with timeout-bounded `curl` retries; packing hashes that explicit path.
 - Done: updated release-channel docs and changelog with the Chocolatey moderation state and fix.
-- Verification: XML/SVG syntax checks, PowerShell parser checks, extracted workflow parser checks, simulated `Pack and push` workflow dry runs against old `v0.1.85` tag contents, local `dotnet pack` smoke for the Chocolatey nuspec, install-script shim-path stub test, `git diff --check`, local identity scan, and full `./scripts/verify` passed.
-- Next: commit/push the noninteractive asset-download follow-up, then dispatch `Publish Chocolatey` for the current release tag. If Chocolatey requires it, self-reject or ask the moderator to reject stale `0.1.68` first.
+- Verification: XML/SVG syntax checks, PowerShell parser checks, extracted workflow parser checks, extracted bash parser check, local curl download/checksum for the `v0.1.85` Windows ZIP, simulated `Pack and push` workflow dry runs against old `v0.1.85` tag contents, local `dotnet pack` smoke for the Chocolatey nuspec, install-script shim-path stub test, `git diff --check`, local identity scan, and full `./scripts/verify` passed.
+- Next: commit/push the timeout-bounded asset-download follow-up, then dispatch `Publish Chocolatey` for the current release tag. If Chocolatey requires it, self-reject or ask the moderator to reject stale `0.1.68` first.
 
 **Current (2026-06-16):** Fix COPR publishing credentials and rerun `v0.1.85`.
 
diff --git a/memory-bank/task_history.md b/memory-bank/task_history.md
@@ -425,6 +425,6 @@
 - Corrected `packaging/chocolatey/tools/chocolateyinstall.ps1` so the explicit shim target points at the nested release ZIP executable path, `iptv-tunerr-$releaseTag-windows-amd64\iptv-tunerr.exe`.
 - Hardened `.github/workflows/publish-chocolatey.yml` so the `Pack and push` step rewrites the full nuspec and install script at runtime before `choco pack`. This lets an existing tag such as `v0.1.85` be republished with corrected Chocolatey metadata even though the tag itself predates the packaging fix.
 - After commit `f09c6d5` was pushed, the first Chocolatey dispatch queued indefinitely because no online runner matched the old Windows runner labels. Canceled that queued run and changed Chocolatey publishing to the repo Linux runner pool, using `dotnet pack` against the nuspec and `dotnet nuget push` to publish the generated `.nupkg`. The first Linux dispatch reached `actions/setup-dotnet` but failed because it tried to install under `/usr/share/dotnet` without permission; the follow-up constrains `DOTNET_INSTALL_DIR` to runner temp.
-- A follow-up Linux dispatch then hung in the release ZIP download step on the reused self-hosted workspace, so the workflow now downloads the Windows ZIP into a runner-temp asset directory with `--clobber` and hashes that explicit file during packing.
+- A follow-up Linux dispatch then hung in the release ZIP download step on the reused self-hosted workspace, so the workflow now downloads the Windows ZIP into a runner-temp asset directory with timeout-bounded `curl` retries and hashes that explicit file during packing.
 - Updated the release-channel guide and changelog with the moderation state and remediation.
 - Verification: `xmllint` on the nuspec and SVG, PowerShell parser checks, extracted workflow parser checks after replacing GitHub expressions, simulated `Pack and push` dry run against old `v0.1.85` tag contents with a fake `choco`, local `dotnet pack` smoke for the Chocolatey nuspec, install-script shim-path stub test, `git diff --check`, local identity scan, and full `./scripts/verify` passed. `scripts/verify` regenerated tracked council scan files.
