HERFD Analyzer has error while start_haven/start_firefly

[yannachen]

Describe the bug

(base) [s25idcuser@microprobe ~]$ start_firefly
✨ Pixi task (firefly in 25idc): firefly                                        I Thu-01:41:31.808: **************************************** Bluesky Startup
I Thu-01:41:33.095: Forcing use of PyQt5 as Qt Implementation
I Thu-01:41:33.695: Available styles: ['Windows', 'Fusion']
[2026-02-12 01:41:33,695] [INFO    ] - Available styles: ['Windows', 'Fusion']
Traceback (most recent call last):
  File "/home/beams0/S25IDCUSER/src/haven/.pixi/envs/25idc/bin/firefly", line 10, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/beams0/S25IDCUSER/src/haven/src/firefly/launcher.py", line 193, in main
    event_loop.run_until_complete(run_app())
  File "/home/beams0/S25IDCUSER/src/haven/.pixi/envs/25idc/lib/python3.12/site-packages/qasync/__init__.py", line 438, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/home/beams0/S25IDCUSER/src/haven/src/firefly/launcher.py", line 182, in run_app
    await controller.setup_instrument(load_instrument=not pydm_args.no_instrument)
  File "/home/beams0/S25IDCUSER/src/haven/src/firefly/controller.py", line 112, in setup_instrument
    beamline.load()
  File "/home/beams0/S25IDCUSER/src/haven/src/haven/instrument.py", line 72, in load
    super().load(cfg_file, return_exceptions=True)
  File "/home/beams0/S25IDCUSER/src/haven/.pixi/envs/25idc/lib/python3.12/site-packages/guarneri/instrument.py", line 485, in load
    devices = self.make_devices(device_defns, fake=fake)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/beams0/S25IDCUSER/src/haven/.pixi/envs/25idc/lib/python3.12/site-packages/guarneri/instrument.py", line 222, in make_devices
    self.validate_params(defn["kwargs"], Klass)
  File "/home/beams0/S25IDCUSER/src/haven/.pixi/envs/25idc/lib/python3.12/site-packages/guarneri/instrument.py", line 266, in validate_params
    raise InvalidConfiguration(
guarneri.exceptions.InvalidConfiguration: Missing required key 'prefix' for <class 'haven.devices.asymmotron.Analyzer'>: {'name': 'herfd_analyzer', 'yaw_motor_prefix': '25idcVME:m28', 'chord_motor_prefix': '25idcVME:m68', 'pitch_motor_prefix': '25idcVME:m69', 'rowland_diameter': 0.5, 'lattice_constant': 0.543095, 'wedge_angle': 0.0, 'surface_plane': '211'}

To Reproduce

Expected behavior

Screenshots

Environment

Additional context

[canismarko]

Thanks for submitting the issue.

The last line of the stack trace shows an InvalidConfiguration exception, which happens when the configuration file does not match the arguments that the device expect.
guarneri.exceptions.InvalidConfiguration: Missing required key 'prefix' for <class 'haven.devices.asymmotron.Analyzer'>: {'name': 'herfd_analyzer', 'yaw_motor_prefix': '25idcVME:m28', 'chord_motor_prefix': '25idcVME:m68', 'pitch_motor_prefix': '25idcVME:m69', 'rowland_diameter': 0.5, 'lattice_constant': 0.543095, 'wedge_angle': 0.0, 'surface_plane': '211'}

In this case, you're missing the "prefix" argument, which should be the IOC prefix for the new records we added last week, (25idc:asymm0: through 25idc:asymm2 IIRC).

Maybe the resolution to the issue is that the exception message needs to be refined even more? Any suggestions there?

[canismarko]

@yannachen Is it working now? Can this issue be closed?