MemoryError in logs and broadcast tx package

[biatwc]

Hello there

I've noticed the below error quite a bit recently and it got me thinking, is the 1MB limit in aiorpcx (which is where this error comes from) going to be an issue when clients are now sending broadcast_package messages (which I assume could easily hit this limit)?

ClientSession - MemoryError('dropping message over 1,000,000 bytes and re-synchronizing')

Grateful for your thoughts.

[SomberNight]

You can set the MAX_RECV envvar to be higher.

electrumx/docs/environment.rst

Lines 302 to 308 in c5fb27e

	.. envvar:: MAX_RECV
	The maximum size of an incoming message in bytes, the default is 1,000,000 bytes.
	Note that the smallest sane/safe value for Bitcoin is ~800,100 bytes,
	as the largest standard tx can have a weight of 400K but the protocol hex-encodes that,
	plus there is a few bytes of protocol overhead. Setting this to lower than that
	would preclude clients from broadcasting txs that could propagate over the network.

going to be an issue when clients are now sending broadcast_package messages (which I assume could easily hit this limit)?

I don't know, could it? I am not sure what the max standard-policy size of package is, but I would guess it is still 400k weight units (?)

see https://github.com/bitcoin/bitcoin/blob/d5c8199b7904f4b13230d5677d4528591e4d5b41/doc/policy/packages.md?plain=1#L19-L20
(but not sure if/how cluster mempool changes that)