Skip to content

Commit 27bc394

Browse files
committed
Fix event names to be Symbol
1 parent 39b043a commit 27bc394

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

lib/vident/stimulus_attributes.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@ module StimulusAttributes
55
extend ActiveSupport::Concern
66

77
class_methods do
8-
# Class methods for generating scoped event names
8+
# Class methods for generating scoped event names. Returns a symbol
9+
# so that the action parser will see it as a Stimulus event.
910
def stimulus_scoped_event(event)
10-
"#{component_name}:#{stimulus_js_name(event)}"
11+
"#{component_name}:#{stimulus_js_name(event)}".to_sym
1112
end
1213

1314
def stimulus_scoped_event_on_window(event)
14-
"#{component_name}:#{stimulus_js_name(event)}@window"
15+
"#{component_name}:#{stimulus_js_name(event)}@window".to_sym
1516
end
1617

1718
private

test/components/greeters/greeter_with_trigger_component_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,8 +263,8 @@ def test_component_stimulus_identifier_path
263263

264264
def test_component_stimulus_scoped_events
265265
expected_prefix = "greeters--greeter-with-trigger-component"
266-
assert_equal "#{expected_prefix}:click", Greeters::GreeterWithTriggerComponent.stimulus_scoped_event(:click)
267-
assert_equal "#{expected_prefix}:click@window", Greeters::GreeterWithTriggerComponent.stimulus_scoped_event_on_window(:click)
266+
assert_equal :"#{expected_prefix}:click", Greeters::GreeterWithTriggerComponent.stimulus_scoped_event(:click)
267+
assert_equal :"#{expected_prefix}:click@window", Greeters::GreeterWithTriggerComponent.stimulus_scoped_event_on_window(:click)
268268
end
269269

270270
def test_root_element_attributes_structure

test/components/phlex_greeters/greeter_with_trigger_component_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,8 @@ def test_component_stimulus_identifier_path
223223

224224
def test_component_stimulus_scoped_events
225225
expected_prefix = "phlex-greeters--greeter-with-trigger-component"
226-
assert_equal "#{expected_prefix}:click", PhlexGreeters::GreeterWithTriggerComponent.stimulus_scoped_event(:click)
227-
assert_equal "#{expected_prefix}:click@window", PhlexGreeters::GreeterWithTriggerComponent.stimulus_scoped_event_on_window(:click)
226+
assert_equal :"#{expected_prefix}:click", PhlexGreeters::GreeterWithTriggerComponent.stimulus_scoped_event(:click)
227+
assert_equal :"#{expected_prefix}:click@window", PhlexGreeters::GreeterWithTriggerComponent.stimulus_scoped_event_on_window(:click)
228228
end
229229

230230
def test_root_element_attributes_structure

0 commit comments

Comments
 (0)