fix(zsh): prevent terminal hang during sync and improve command execution (#2333)

Author: tusharmath

shell-plugin/lib/actions/config.zsh

@@ -96,7 +96,9 @@ function _forge_action_model() {
 # Action handler: Sync workspace for codebase search
 function _forge_action_sync() {
     echo
-    _forge_exec workspace sync
+    # Execute sync with stdin redirected to prevent hanging
+    # Sync doesn't need interactive input, so close stdin immediately
+    _forge_exec workspace sync </dev/null
 }
 
 # Helper function to select and set config values with fzf

shell-plugin/lib/actions/git.zsh

@@ -19,9 +19,6 @@ function _forge_action_commit() {
     else
         commit_message=$(FORCE_COLOR=true CLICOLOR_FORCE=1 $_FORGE_BIN commit --max-diff "$_FORGE_MAX_COMMIT_DIFF")
     fi
-    
-    BUFFER=""
-    CURSOR=0
     zle reset-prompt
 }
 
@@ -49,10 +46,10 @@ function _forge_action_commit_preview() {
         # Check if there are staged changes to determine commit strategy
         if git diff --staged --quiet; then
             # No staged changes: commit all tracked changes with -a flag
-            BUFFER="git commit -a -m '$commit_message'"
+            BUFFER="git commit -am ${(qq)commit_message}"
         else
             # Staged changes exist: commit only what's staged
-            BUFFER="git commit -m '$commit_message'"
+            BUFFER="git commit -m ${(qq)commit_message}"
         fi
         # Move cursor to end of buffer for immediate execution
         CURSOR=${#BUFFER}

shell-plugin/lib/dispatcher.zsh

@@ -110,13 +110,11 @@ function forge-accept-line() {
     # Add the original command to history before transformation
     print -s -- "$original_buffer"
 
-    # CRITICAL: For multiline buffers, move cursor to end so output doesn't overwrite
+    # CRITICAL: Move cursor to end so output doesn't overwrite
     # Don't clear BUFFER yet - let _forge_reset do that after action completes
     # This keeps buffer state consistent if Ctrl+C is pressed
-    if [[ "$BUFFER" == *$'\n'* ]]; then
-        CURSOR=${#BUFFER}
-        zle redisplay
-    fi
+    CURSOR=${#BUFFER}
+    zle redisplay
 
     # Handle aliases - convert to their actual agent names
     case "$user_action" in

shell-plugin/lib/helpers.zsh

@@ -19,10 +19,10 @@ function _forge_fzf() {
 # Helper function to execute forge commands consistently
 # This ensures proper handling of special characters and consistent output
 function _forge_exec() {
-    # Ensure FORGE_ACTIVE_AGENT always has a value, default to "forge"
     local agent_id="${_FORGE_ACTIVE_AGENT:-forge}"
-    
-    eval "$_FORGE_BIN --agent $(printf '%q' "$agent_id") $(printf '%q ' "$@")"
+    local -a cmd
+    cmd=($_FORGE_BIN --agent "$agent_id" "$@")
+    "${cmd[@]}"
 }
 
 function _forge_reset() {
@@ -130,8 +130,9 @@ function _forge_start_background_sync() {
 
     # Run sync once in background
     # Close all output streams immediately to prevent any flashing
+    # Redirect stdin to /dev/null to prevent hanging if sync tries to read input
     {
-        exec >/dev/null 2>&1
+        exec >/dev/null 2>&1 </dev/null
         setopt NO_NOTIFY NO_MONITOR
         $_FORGE_BIN workspace sync "$workspace_path"
     } &!