Merge pull request #375 from takumin/codex/add-validation-for-self.dir-in-profile

Validate profile dir is a directory

Author: takumin

src/config.rs

@@ -7,7 +7,7 @@
 //! The configuration is typically loaded from YAML files using the
 //! `load_profile` function.
 
-use anyhow::{Context, Ok, Result};
+use anyhow::{Context, Ok, Result, bail};
 use camino::{Utf8Path, Utf8PathBuf};
 use serde::Deserialize;
 use std::fs::File;
@@ -63,6 +63,9 @@ impl Bootstrap {
 impl Profile {
     /// Validate configuration semantics beyond basic deserialization.
     pub fn validate(&self) -> Result<()> {
+        if self.dir.exists() && !self.dir.is_dir() {
+            bail!("dir must be a directory: {}", self.dir);
+        }
         for (index, provisioner) in self.provisioners.iter().enumerate() {
             provisioner
                 .validate()

tests/config_test.rs

@@ -277,6 +277,32 @@ provisioners:
     Ok(())
 }
 
+#[test]
+fn test_profile_validation_rejects_dir_file() -> Result<()> {
+    let dir_file = NamedTempFile::new()?;
+    let mut file = NamedTempFile::new()?;
+    // editorconfig-checker-disable
+    writeln!(
+        file,
+        r#"---
+dir: {}
+bootstrap:
+  type: mmdebstrap
+  suite: bookworm
+  target: rootfs.tar.zst
+"#,
+        dir_file.path().display()
+    )?;
+    // editorconfig-checker-enable
+
+    let path = Utf8Path::from_path(file.path()).unwrap();
+    let profile = load_profile(path)?;
+
+    assert!(profile.validate().is_err());
+
+    Ok(())
+}
+
 #[test]
 fn test_load_profile_resolves_shell_script_relative_to_profile_dir() -> Result<()> {
     let temp_dir = tempdir()?;