Merge pull request #33 from teams-notifier/feat/fingerprint-optim-and-tests

feat: refactor fingerprint (DB UPDATE REQUIRED) and add tests

Author: babs

.env.example

@@ -0,0 +1,20 @@
+# Logging Configuration
+# LOG_FORMAT: "json" = force JSON, "line" = force line format, "auto" = TTY detection (default)
+LOG_FORMAT=auto
+
+# LOG_LEVEL: DEBUG, INFO, WARNING, ERROR, CRITICAL (default: INFO)
+LOG_LEVEL=INFO
+
+# Database
+# pragma: allowlist nextline secret
+DATABASE_URL=postgresql://user:password@localhost:5432/gitlab_mr_api?options=-c%20search_path%3Dgitlab_mr_api
+
+# Activity API
+ACTIVITY_API=http://localhost:3981/
+
+# GitLab Tokens (comma-separated)
+GITLAB_TOKENS=token1,token2
+
+# OpenTelemetry (optional)
+OTEL_PYTHON_EXCLUDED_URLS=healthz
+OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4318

.github/workflows/ci.yml

@@ -0,0 +1,20 @@
+name: CI
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: actions/setup-python@v6
+        with:
+          python-version: "3.12"
+      - uses: pre-commit/action@v3.0.1
+      - uses: astral-sh/setup-uv@v7
+      - run: uv venv
+      - run: uv pip install -r requirements.txt -r requirements-dev.txt
+      - run: .venv/bin/pytest --cov

.gitignore

@@ -3,3 +3,6 @@
 __pycache__
 misc
 .vscode
+.coverage
+.pytest_cache
+*.pyc

.pre-commit-config.yaml

@@ -5,7 +5,6 @@ repos:
     rev: 24.10.0
     hooks:
       - id: black
-        args: [--safe, --line-length=110]
 
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v5.0.0
@@ -50,20 +49,7 @@ repos:
     rev: v1.11.2
     hooks:
       - id: mypy
-        #    files: ^*.py
         additional_dependencies:
           - pydantic
           - types-PyYAML
           - types-python-dateutil
-        args:
-          - --check-untyped-defs
-          - --disallow-any-generics
-          - --ignore-missing-imports
-          - --no-implicit-optional
-          - --show-error-codes
-          - --strict-equality
-          - --warn-redundant-casts
-          - --warn-return-any
-          - --warn-unreachable
-          - --warn-unused-configs
-          - --no-implicit-reexport

db/migrations/20250121010000_refactor_fingerprint_to_message_ref.sql

@@ -0,0 +1,23 @@
+-- migrate:up
+
+-- Add fingerprint column to message ref table
+ALTER TABLE gitlab_mr_api.merge_request_message_ref
+ADD COLUMN last_processed_fingerprint VARCHAR(64);
+
+-- Drop global fingerprint table (no longer needed)
+DROP TABLE gitlab_mr_api.webhook_fingerprint;
+
+-- migrate:down
+
+-- Recreate global fingerprint table
+CREATE TABLE gitlab_mr_api.webhook_fingerprint (
+    fingerprint character varying(64) NOT NULL,
+    processed_at timestamp with time zone DEFAULT now() NOT NULL
+);
+
+ALTER TABLE ONLY gitlab_mr_api.webhook_fingerprint
+    ADD CONSTRAINT webhook_fingerprint_pkey PRIMARY KEY (fingerprint);
+
+-- Remove fingerprint column from message ref
+ALTER TABLE gitlab_mr_api.merge_request_message_ref
+DROP COLUMN last_processed_fingerprint;

db/schema.sql

@@ -81,7 +81,8 @@ CREATE TABLE gitlab_mr_api.merge_request_message_ref (
     message_id uuid,
     failure jsonb,
     created_at timestamp with time zone DEFAULT now() NOT NULL,
-    updated_at timestamp with time zone
+    updated_at timestamp with time zone,
+    last_processed_fingerprint character varying(64)
 );
 
 
@@ -226,6 +227,7 @@ ALTER TABLE ONLY gitlab_mr_api.msg_to_delete
     ADD CONSTRAINT msg_to_delete_pkey PRIMARY KEY (msg_to_delete_id);
 
 
+
 --
 -- Name: schema_migrations schema_migrations_pkey; Type: CONSTRAINT; Schema: gitlab_mr_api; Owner: -
 --