Skip to content

fix[notask]: add no and th to BERGAMOT_LANGUAGES enum#2456

Open
RamazTs wants to merge 2 commits into
mainfrom
fix/bergamot-languages-add-no-th
Open

fix[notask]: add no and th to BERGAMOT_LANGUAGES enum#2456
RamazTs wants to merge 2 commits into
mainfrom
fix/bergamot-languages-add-no-th

Conversation

@RamazTs

@RamazTs RamazTs commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • BERGAMOT_LANGUAGES enum in packages/sdk/schemas/translation-config.ts was missing "no" and "th" despite the registry shipping working model constants for both
  • BERGAMOT_EN_NO, BERGAMOT_NO_EN, BERGAMOT_EN_TH, BERGAMOT_TH_EN resolve to real registry:// blobs (model + lex + vocab + metadata, dated 2026-04-28)
  • But loadModel({ modelType: "nmt", modelConfig: { engine: "Bergamot", from: "en", to: "no" } }) (and the three sibling directions) was rejected with a zod invalid_union error at validation — four shipped pairs unreachable through the SDK

📝 How does it solve it?

  • Add "no" and "th" to the BERGAMOT_LANGUAGES const tuple in their alphabetical slots
  • Net diff: 2 lines added, no other changes; discriminated-union nmtConfigSchema now accepts the missing codes

🧪 How was it tested?

  • bun run typecheck in packages/sdk — clean
  • Surfaced by the QVAC-18959 SDK translation sanity-test suite (separate PR): under that suite, bergamot-en-no and bergamot-en-th consistently failed at the consumer's loadModel step with a zod invalid_union error pointing at modelConfig.from/to; every other bergamot pair loaded and translated fine. After this fix the 4 affected pairs (en-no, no-en, en-th, th-en) become usable through the SDK

@RamazTs RamazTs requested review from a team as code owners June 4, 2026 16:43
@RamazTs RamazTs added tier1 test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] verified Authorize secrets / label-gate in PR workflows labels Jun 4, 2026
@RamazTs RamazTs added test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] and removed test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] labels Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — ios — ✅ all tests passed (82/94, 818s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — android — ✅ all tests passed (84/94, 1662s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — windows — ✅ all tests passed (94/94, 449s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — linux — ✅ all tests passed (94/94, 349s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — macos⚠️ no results

Config: suite=smoke · filter=(none) · exclude=(none)
View run

The test job did not produce a results artifact. Check the run for job-level failures.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ❌ PENDING

**Requirements:**
- 1 Team Member approval ❌ (0/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] tier1 verified Authorize secrets / label-gate in PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants