fix[notask]: add no and th to BERGAMOT_LANGUAGES enum#2456
Open
RamazTs wants to merge 2 commits into
Open
Conversation
Contributor
QVAC E2E —
|
Contributor
QVAC E2E —
|
Contributor
Contributor
Contributor
QVAC E2E —
|
olyasir
approved these changes
Jun 8, 2026
Contributor
Tier-based Approval Status |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
BERGAMOT_LANGUAGESenum inpackages/sdk/schemas/translation-config.tswas missing"no"and"th"despite the registry shipping working model constants for bothBERGAMOT_EN_NO,BERGAMOT_NO_EN,BERGAMOT_EN_TH,BERGAMOT_TH_ENresolve to realregistry://blobs (model + lex + vocab + metadata, dated 2026-04-28)loadModel({ modelType: "nmt", modelConfig: { engine: "Bergamot", from: "en", to: "no" } })(and the three sibling directions) was rejected with a zodinvalid_unionerror at validation — four shipped pairs unreachable through the SDK📝 How does it solve it?
"no"and"th"to theBERGAMOT_LANGUAGESconst tuple in their alphabetical slotsnmtConfigSchemanow accepts the missing codes🧪 How was it tested?
bun run typecheckinpackages/sdk— cleanbergamot-en-noandbergamot-en-thconsistently failed at the consumer'sloadModelstep with a zodinvalid_unionerror pointing atmodelConfig.from/to; every other bergamot pair loaded and translated fine. After this fix the 4 affected pairs (en-no,no-en,en-th,th-en) become usable through the SDK