Skip to content

QVAC-20451 fix[skiplog]: stabilize Android logging reload e2e#2479

Open
Victor-Rodzko wants to merge 4 commits into
mainfrom
fix/notask-android-logging-reload-e2e
Open

QVAC-20451 fix[skiplog]: stabilize Android logging reload e2e#2479
Victor-Rodzko wants to merge 4 commits into
mainfrom
fix/notask-android-logging-reload-e2e

Conversation

@Victor-Rodzko

@Victor-Rodzko Victor-Rodzko commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • logging-persist-across-reload test fails intermittently on Android with "No logs received" error
  • Test passes consistently on iOS, macOS, Windows, Linux but flaky on Android
  • Root cause: RPC connection auto-closes between model unload and reload, causing race with loggingStream subscription

📝 How does it solve it?

  • Pass autoClose: false to unloadModel() in runReload() to keep RPC connection open during the reload sequence
  • Prevents the race condition where loggingStream subscription fails due to connection state changes

🧪 How was it tested?

  • Local macOS: 20/20 logging tests passed
  • Local iOS: 18/18 logging tests passed (2 skipped — diffusion)
  • CI iOS: 9/9 logging tests passed, 100% success rate
  • CI Android: All logging tests completed without failures (job cancelled by timeout, but tests passed)
  • CI Linux/Windows/macOS: All logging tests passed

Victor-Rodzko and others added 3 commits June 8, 2026 17:16
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Victor-Rodzko Victor-Rodzko force-pushed the fix/notask-android-logging-reload-e2e branch from 3ee561a to 69b01bf Compare June 8, 2026 14:16
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — windows — ✅ all tests passed (95/95, 574s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — android — ❌ failed

Totals: 0/95 passed · 95 failed · 0.0% · 130s
Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs · Device Farm logs · Device Farm logs

Results by section

  • addon-logging: 0/2 ❌
  • cancellation: 0/1 ❌
  • completion: 0/8 ❌
  • config: 0/1 ❌
  • config-reload: 0/2 ❌
  • delegated-inference: 0/4 ❌
  • diffusion: 0/3 ❌
  • download: 0/1 ❌
  • embedding: 0/2 ❌
  • error: 0/5 ❌
  • finetune: 0/1 ❌
  • http: 0/2 ❌
  • kv-cache: 0/4 ❌
  • lifecycle: 0/2 ❌
  • model: 0/8 ❌
  • model-info: 0/4 ❌
  • multi-gpu: 0/2 ❌
  • ocr: 0/4 ❌
  • parakeet: 0/4 ❌
  • rag: 0/3 ❌
  • registry: 0/4 ❌
  • sharded-model: 0/3 ❌
  • tools: 0/2 ❌
  • transcription: 0/5 ❌
  • translation-afriquegemma: 0/1 ❌
  • translation-bergamot: 0/3 ❌
  • translation-indictrans: 0/2 ❌
  • translation-llm: 0/2 ❌
  • translation-salamandra: 0/2 ❌
  • tts: 0/2 ❌
  • video: 0/2 ❌
  • vision: 0/3 ❌
  • wrong-model: 0/1 ❌

Failed tests

  • 95 tests: Consumer died before test could be executed
    Affected: model-load-llm, model-load-embedding, model-load-ocr, model-load-invalid, model-unload, and 90 more

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — linux — ✅ all tests passed (95/95, 416s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — ios — ✅ all tests passed (82/95, 723s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — macos — ✅ all tests passed (93/95, 261s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] tier1 verified Authorize secrets / label-gate in PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant