Use cts.Token for delay in transaction polling

0xFirekeeper · 0xFirekeeper · commit 2edf6ef1b52c · 2025-09-25T01:25:42.000+07:00
Replaces usage of cancellationToken with cts.Token in delay calls within transaction receipt polling loops in both ThirdwebTransaction.cs and Utils.cs. This ensures consistent cancellation behavior aligned with the controlling CancellationTokenSource.
diff --git a/Thirdweb/Thirdweb.Transactions/ThirdwebTransaction.cs b/Thirdweb/Thirdweb.Transactions/ThirdwebTransaction.cs
@@ -422,7 +422,7 @@ public static async Task<ThirdwebTransactionReceipt> WaitForTransactionReceipt(T
                 receipt = await rpc.SendRequestAsync<ThirdwebTransactionReceipt>("eth_getTransactionReceipt", txHash).ConfigureAwait(false);
                 if (receipt == null)
                 {
-                    await ThirdwebTask.Delay(100, cancellationToken).ConfigureAwait(false);
+                    await ThirdwebTask.Delay(100, cts.Token).ConfigureAwait(false);
                 }
             } while (receipt == null && !cts.Token.IsCancellationRequested);
 
diff --git a/Thirdweb/Thirdweb.Utils/Utils.cs b/Thirdweb/Thirdweb.Utils/Utils.cs
@@ -1176,7 +1176,7 @@ public static async Task<ThirdwebTransactionReceipt> WaitForTransactionReceipt(T
                 receipt = await rpc.SendRequestAsync<ThirdwebTransactionReceipt>("eth_getTransactionReceipt", txHash).ConfigureAwait(false);
                 if (receipt == null)
                 {
-                    await ThirdwebTask.Delay(100, cancellationToken).ConfigureAwait(false);
+                    await ThirdwebTask.Delay(100, cts.Token).ConfigureAwait(false);
                 }
             } while (receipt == null && !cts.Token.IsCancellationRequested);
 

Original file line number	Diff line number	Diff line change
`@@ -422,7 +422,7 @@ public static async Task<ThirdwebTransactionReceipt> WaitForTransactionReceipt(T`
`422`	`422`	`receipt = await rpc.SendRequestAsync<ThirdwebTransactionReceipt>("eth_getTransactionReceipt", txHash).ConfigureAwait(false);`
`423`	`423`	`if (receipt == null)`
`424`	`424`	`{`
`425`		`- await ThirdwebTask.Delay(100, cancellationToken).ConfigureAwait(false);`
	`425`	`+ await ThirdwebTask.Delay(100, cts.Token).ConfigureAwait(false);`
`426`	`426`	`}`
`427`	`427`	`} while (receipt == null && !cts.Token.IsCancellationRequested);`
`428`	`428`
Original file line number	Diff line number	Diff line change
`@@ -1176,7 +1176,7 @@ public static async Task<ThirdwebTransactionReceipt> WaitForTransactionReceipt(T`
`1176`	`1176`	`receipt = await rpc.SendRequestAsync<ThirdwebTransactionReceipt>("eth_getTransactionReceipt", txHash).ConfigureAwait(false);`
`1177`	`1177`	`if (receipt == null)`
`1178`	`1178`	`{`
`1179`		`- await ThirdwebTask.Delay(100, cancellationToken).ConfigureAwait(false);`
	`1179`	`+ await ThirdwebTask.Delay(100, cts.Token).ConfigureAwait(false);`
`1180`	`1180`	`}`
`1181`	`1181`	`} while (receipt == null && !cts.Token.IsCancellationRequested);`
`1182`	`1182`