Skip to content

feat(duckdb): Support DuckDB table functions#7410

Merged
georgesittas merged 2 commits intotobymao:mainfrom
pittst3r:duckdb-table-functions
Mar 31, 2026
Merged

feat(duckdb): Support DuckDB table functions#7410
georgesittas merged 2 commits intotobymao:mainfrom
pittst3r:duckdb-table-functions

Conversation

@pittst3r
Copy link
Copy Markdown
Contributor

@pittst3r pittst3r commented Mar 29, 2026

This PR adds parser and generator support for DuckDB's table function/macro syntax.

Copy link
Copy Markdown
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pittst3r, left some comments.

@pittst3r pittst3r force-pushed the duckdb-table-functions branch from 5660aa2 to 26ea155 Compare March 30, 2026 22:12
@pittst3r
Copy link
Copy Markdown
Contributor Author

Thanks for the quick and helpful review @georgesittas. I've updated the PR according to your feedback and added an update to the databricks generator that wraps a exp.Select node in a exp.Return node if needed.

I don't have a databricks account so I didn't try it, but in looking at their docs and referencing a similar test in test_databricks.py, it seems like this updated test is correct. To clarify, I'm not seeking to make any updates to databricks code here specifically, but thought it best to ensure duckdb -> databricks transpilation of table functions is supported given databricks -> duckdb is. Does including that in this PR make sense?

@pittst3r pittst3r requested a review from georgesittas March 30, 2026 22:43
@georgesittas
Copy link
Copy Markdown
Collaborator

Thanks for the quick turnaround, Robert.

@georgesittas georgesittas merged commit 8bebadf into tobymao:main Mar 31, 2026
2 of 8 checks passed
@pittst3r pittst3r deleted the duckdb-table-functions branch April 1, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants