Filed by greptile-iterator from rejected (out-of-scope-for-PR) greptile suggestion.
Source PR: #63
Source thread: #63 (comment)
File: Sources/ColumbaApp/Views/NomadNet/MonospaceLineView.swift:171-174
What greptile suggested
The minWidth field on MonospaceLineView / UIMonospaceLine is declared and threaded through the chain, but sizeThatFits never applies it. The documented contract ("Force the UIKit label to be at least this wide…") is not enforced. All callers use the default 0 and minimum-width is in fact enforced one level up via .frame(minWidth: viewportWidth, alignment:) in MicronDocumentView.
Why it was deferred
Out of scope for the source PR — that PR's intent is fixing the chat-room rendering (parser cross-line state, JetBrains Mono bundling, viewport min-width at the SwiftUI layer). Touching UIMonospaceLine's API surface is adjacent cleanup, not a bug fix.
The dead plumbing is harmless today (the field defaults to 0, so nothing changes), but it's misleading: a future contributor will reach for minWidth expecting it to do what the doc-comment says, and it won't.
Suggested follow-up
Remove the minWidth field from MonospaceLineView and UIMonospaceLine, along with the Pass 0 to opt out… doc-comment. The author's intentional strategy is that minimum-width enforcement lives at the SwiftUI layer in MicronDocumentView (avoids Core Text's trailing-whitespace stripping under textAlignment = .center). Codify that decision by removing the dead alternative path.
Alternatively, if there's a future scenario where UIKit-level min-width is wanted (different from SwiftUI .frame(minWidth:)), wire sizeThatFits to honor it (max(intrinsicWidth, minWidth)) and add a passing call site that uses it.
🤖 Filed by greptile-iterator. Rationale + full audit trail in <vault>/80 Assistant/Agent Plans/Columba-iOS-issue-31/REJECTIONS.md.
Filed by
greptile-iteratorfrom rejected (out-of-scope-for-PR) greptile suggestion.Source PR: #63
Source thread: #63 (comment)
File:
Sources/ColumbaApp/Views/NomadNet/MonospaceLineView.swift:171-174What greptile suggested
Why it was deferred
Out of scope for the source PR — that PR's intent is fixing the chat-room rendering (parser cross-line state, JetBrains Mono bundling, viewport min-width at the SwiftUI layer). Touching
UIMonospaceLine's API surface is adjacent cleanup, not a bug fix.The dead plumbing is harmless today (the field defaults to
0, so nothing changes), but it's misleading: a future contributor will reach forminWidthexpecting it to do what the doc-comment says, and it won't.Suggested follow-up
Remove the
minWidthfield fromMonospaceLineViewandUIMonospaceLine, along with thePass 0 to opt out…doc-comment. The author's intentional strategy is that minimum-width enforcement lives at the SwiftUI layer inMicronDocumentView(avoids Core Text's trailing-whitespace stripping undertextAlignment = .center). Codify that decision by removing the dead alternative path.Alternatively, if there's a future scenario where UIKit-level min-width is wanted (different from SwiftUI
.frame(minWidth:)), wiresizeThatFitsto honor it (max(intrinsicWidth, minWidth)) and add a passing call site that uses it.🤖 Filed by greptile-iterator. Rationale + full audit trail in
<vault>/80 Assistant/Agent Plans/Columba-iOS-issue-31/REJECTIONS.md.