Stop hooks are not run if process is terminated during startup, am I doing something wrong?

[andersroos]

I have tested this with a simple app. If I have two dependent Start hooks and interrupt the process while the second one is running, the app will just exit with code 1. I assumed that the first Stop hook would run and the app would exit gracefully. Am I doing something wrong?

Sample code:

type Dependency struct{}

func NewDependency(lc fx.Lifecycle) *Dependency {
	lc.Append(fx.Hook{
		OnStart: func(ctx context.Context) error {
			fmt.Println("starting dependency")
			return nil
		},
		OnStop: func(ctx context.Context) error {
			fmt.Println("stopping dependency, will not run if interrupted during startup")
			return nil
		},
	})

	return &Dependency{}
}

type InterruptedStartup struct{}

func NewInterruptedStartup(lc fx.Lifecycle) *InterruptedStartup {
	lc.Append(fx.Hook{
		OnStart: func(ctx context.Context) error {
			fmt.Println("starting long startup, sleeping, INTERRUPT ME NOW")
			// sleep is just here to have time to interrupt manually, know that Start is supposed to be fast
			time.Sleep(10 * time.Second)
			return nil
		},
		OnStop: func(ctx context.Context) error {
			fmt.Println("stopping long startup")
			return nil
		},
	})

	return &InterruptedStartup{}
}

func RunIt(dep *Dependency, ls *InterruptedStartup) {
}

func main() {
	app := fx.New(
		fx.Provide(NewDependency),
		fx.Provide(NewInterruptedStartup),
		fx.Invoke(RunIt),
	)
	app.Run()
}