Skip to content
This repository was archived by the owner on Apr 25, 2024. It is now read-only.

Confirm on device check is insufficient and works on any device in the quorum  #158

@waldenraines

Description

@waldenraines

I'm submitting a…

  • Regression (a behavior that used to work and stopped working in a new release)
  • Bug report
  • Feature request
  • Documentation issue or request
  • Support request

Expected Behavior

Confirm on device works only on the device selected

Current Behavior

Confirm on device works with any supported device in the quorum

Possible Solution

Take the check here and make it more robust:

https://github.com/unchained-capital/caravan/blob/master/src/components/Slices/ConfirmAddress.jsx#L98-L101

Steps to Reproduce (for bugs)

  1. Set up a wallet/address
  2. Confirm on device with either device
  3. Note that you are able to confirm with any device in the quorum (and not just the one selected)

Environment

  • Where are you running caravan: localhost
  • Operating system: Any
  • Browser and version: Any

[walden:~/code/caravan] master+ 130 ± npm ls caravan unchained-bitcoin unchained-wallets; echo -e npm: npm -v \nnode: node -v; uname -a | xargs echo | cut -d " " -f 1,3-15 || sw_vers
caravan@0.2.1 /home/walden/code/caravan
├── unchained-bitcoin@0.0.13
└─┬ unchained-wallets@0.1.1
└── unchained-bitcoin@0.0.12

npm: 6.14.4
node: v12.16.2
Linux 5.7.6-arch1-1 #1 SMP PREEMPT Thu, 25 Jun 2020 00:14:47 +0000 x86_64 GNU/Linux

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions