-
Notifications
You must be signed in to change notification settings - Fork 302
Attestation scripts in CI should not compare directly against STDOUT #6190
Copy link
Copy link
Open
Labels
Description
Currently in ci.yaml the success or failure of attestation checks is:
RESULT=$(./scripts/proofs/tests.sh --check)
echo "Test proof: $RESULT"
if [[ "$RESULT" == "pass" ]]; then
exit 0
elif [[ "$RESULT" == "fail" ]]; then
echo "::error::Tests previously FAILED. Fix and re-run './scripts/proofs/tests.sh'."
exit 1
else
echo "::error::Test proof not found. Run './scripts/proofs/tests.sh', commit the proofs file, and push again."
exit 1
fi
If I want to run the script with --verbose when debugging it also means the CI job will never pass, since --verbose changes stdout.
likely:
- the scripts should return their status via exit code
--verboseshould likely output on stderr instead- the ci script should check against error code, not stdout.
Reactions are currently unavailable