Skip to content

pestpp-glm: stdv in external obs not being used by FOSM #411

@Yasin7795

Description

@Yasin7795

In pestpp-glm (v5.2.23), I am using external observation data that include a standard_deviation column. The 5.2.24 manual (section 4.18.2, external file support) states that when a standard_deviation column is present, those values “will be used as the observation noise standard deviation instead of the weight.” The .rec file from my runs also reports:
“observations have 'standard_deviation' defined – this will be used instead of weight for the observation noise covariance matrix.”

However, from my testing it appears that the FOSM noise covariance is still derived from calibration weights, not from the standard_deviation values.
I tested this by changing standard_deviation values for certain influential observations groups (while keeping calibration weights fixed). The results do not show any apparent change in the posterior parameter distributions calculated using FOSM.
Also, the fosm_reweight file contains values that appear consistent with a reweighting based on calibration weights and residuals (e.g., something like max(w_calib, 1/|res|)), and do not reflect values like max(1/stdv, 1/|res|) as it seems to be implied by the manual.

so despite the manual text and the .rec message, the standard_deviation column in external observation files appears not to be used in GLM’s FOSM noise covariance construction, and the process still seems to rely on calibration weights.

Is pestpp-glm currently intended to use standard_deviation from external observation files for FOSM/posterior noise, or is this functionality not yet implemented/fully wired in the GLM FOSM pipeline?

Thank you in advance for your time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions