Skip to content

Commit f3a3ce6

Browse files
committed
include children count in "task execution completed" span
1 parent 27041a4 commit f3a3ce6

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

  • turbopack/crates/turbo-tasks-backend/src/backend

turbopack/crates/turbo-tasks-backend/src/backend/mod.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1774,7 +1774,11 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
17741774
// at the start of every step.
17751775

17761776
#[cfg(not(feature = "trace_task_details"))]
1777-
let _span = tracing::trace_span!("task execution completed").entered();
1777+
let span = tracing::trace_span!(
1778+
"task execution completed",
1779+
new_children = tracing::field::Empty
1780+
)
1781+
.entered();
17781782
#[cfg(feature = "trace_task_details")]
17791783
let span = tracing::trace_span!(
17801784
"task execution completed",
@@ -1783,6 +1787,7 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
17831787
Ok(value) => display(either::Either::Left(value)),
17841788
Err(err) => display(either::Either::Right(err)),
17851789
},
1790+
new_children = tracing::field::Empty,
17861791
immutable = tracing::field::Empty,
17871792
new_output = tracing::field::Empty,
17881793
output_dependents = tracing::field::Empty,
@@ -1834,6 +1839,7 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
18341839
}
18351840

18361841
let has_new_children = !new_children.is_empty();
1842+
span.record("new_children", new_children.len());
18371843

18381844
if has_new_children {
18391845
self.task_execution_completed_unfinished_children_dirty(&mut ctx, &new_children)

0 commit comments

Comments
 (0)