refactor(AdvancedMarker): improve stability of position and event handlers#866
Merged
usefulthink merged 10 commits intovisgl:mainfrom Feb 5, 2026
Merged
Conversation
rodrigofariow
commented
Nov 5, 2025
rodrigofariow
commented
Nov 5, 2025
rodrigofariow
commented
Nov 5, 2025
usefulthink
requested changes
Feb 3, 2026
Collaborator
usefulthink
left a comment
usefulthink
left a comment
There was a problem hiding this comment.
Thanks for taking the time, and apologies for me taking so long to review and respond to it. If you like, I can take care of the changes myself so we can get this into the 1.8.0 release.
Contributor
Author
|
Hi @usefulthink ! Feel free to make whatever changes to the code you see fit! Cheers |
usefulthink
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there 👋
For a library like this one that relies heavily on correct and stable rendering of useEffect and useMemo dependencies, I suggest we add a useEffectEvent ponyfill, to fill that gap.
This ponyfill is proven to work and the new version of eslint react-hooks plugin, that is already installed, supports verifying and using these events.
I took the freedom to add it in key places like useMapsEventListener and useDomEventListener.