Skip to content

Default zero value pkgHandle breaks v1 compatibility when discovering VFs #1204

Description

@thediveo

Bitten after upgrading from v1.3.1 to c05a276ed0e0 because of needing to deal with netkit network interfaces: LinkByName() uses the unexported and zero valued pkgHandle. Now this is of type Handle which contains an unexported field of type HandleOptions:

type HandleOptions struct {
	lookupByDump     bool
	collectVFInfo    bool
	retryInterrupted bool
}

Notice how collectVFInfo uses opt-in instead of backwards-compatible opt-out. As I hope you'll release in preferably short course a v1.3.2 or v.1.4.0 the current HEAD breaks the v1 contract of not breaking the API including semantics.

Can you please switch from incompatible opt-in to v1 API guarantee-preserving opt-out regarding collecting VF information? Thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions