Fix ENS Proposal Status - #1393
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
|
We're trying to go towards using API/archive service, not the DB. Does the API service not have the right context? |
2919368 to
837b334
Compare
837b334 to
342225b
Compare
| const data = await getCachedAllProposalsFromDaoNode(); | ||
| let proposalTypes = {}; | ||
|
|
||
| if ( |
There was a problem hiding this comment.
This is adding a per-tenant check.
See
export enum GOVERNOR_TYPE {
AGORA = "AGORA",
ALLIGATOR = "ALLIGATOR",
BRAVO = "BRAVO",
ENS = "ENS",
}
Should work for AGORA or ALLIGATOR.
We need to build this muscle, rather than per-tenant toggles.
There was a problem hiding this comment.
Uniswap and ENS are the only BRAVO and ENS governors that we have.
…e and patching next
|
@atomauro What is this PR fixing? The statuses of proposals on the PR match the prod ones. If this was about the bug i raised in slack, that was because of kestra being down. ENS uses CPLS for proposal listing and DB for listing page, it does not depend on DAO node for any data. |
Thanks for flagging it Sudheer, closing this as it's correctly solved now. |
|
@atomauro If you want to upgrade next or remove the pinned version in package.json, do check for migration notes or search for context in slack. I believe there is a reason why we pinned it to that version. Probably a git blame and check for the commit, if it seems safe enough to unpin it do raise a separate PR |
3 participants
No description provided.