Skip to content

[Feature request] --prompt should accept any unique prefix of the proposed Musicbrainz release IDs #693

Description

@ekovac

Repro steps:

  1. Run whipper cd rip --prompt with a CD in the drive that has multiple matching MBIDs. ("Sevens" by Garth Brooks has several TOC-identical pressings, as an example.)
  2. Enter a unique prefix of one of the listed MBIDs ('b9b4c' for 'b9b4cb95-1e34-48f1-b8c2-731cf0cef03a', for example.)

Expected Behavior:

  1. whipper correctly selects the Musicbrainz release entry since the entered value is unambiguous, similar to how git will happily accept shortened commit numbers so long as they are unique prefixes.

Actual Behavior:

  1. whipper says the MBID doesn't match and aborts.

Happy to write a PR for this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions