Skip to content

chore: fix version check in release workflow to exit gracefully#2

Merged
rodneyosodo merged 1 commit intomainfrom
ci
Jan 3, 2026
Merged

chore: fix version check in release workflow to exit gracefully#2
rodneyosodo merged 1 commit intomainfrom
ci

Conversation

@rodneyosodo
Copy link
Member

@rodneyosodo rodneyosodo commented Jan 3, 2026

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Dependency Update

Related Tickets & Documents

  • Related Issue #
  • Closes #

Added/updated tests?

  • Yes
  • No, and this is why:
  • I need help with writing tests

Added/updated documentation

  • Yes
  • No, and this is why:
  • I need help with writing documentation

Notes

Summary by Sourcery

Relax release workflow version check to skip releases when Cargo.toml version is unchanged and bump crate version.

Build:

  • Adjust release workflow to log a warning and skip the release instead of failing when Cargo.toml version is not updated.

Chores:

  • Bump crate version from 0.1.0 to 0.1.1, updating Cargo.lock accordingly.

@coderabbitai
Copy link

coderabbitai bot commented Jan 3, 2026

Warning

Rate limit exceeded

@rodneyosodo has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between a8643b3 and 726dddc.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • Cargo.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 3, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the release GitHub Actions workflow to no longer fail when Cargo.toml version is unchanged, and bumps the crate version from 0.1.0 to 0.1.1.

Flow diagram for updated version check in release workflow

flowchart TD
  A[Start release workflow job] --> B[Set BASE_REF]
  B --> C[Run git diff BASE_REF..HEAD on Cargo.toml]
  C --> D{Was version line changed?}
  D -- Yes --> E[echo ✅ Cargo.toml version was updated]
  E --> F[Run release-plz]
  D -- No --> G[echo ⚠️ Cargo.toml version was NOT updated - skipping release]
  G --> H[Skip release-plz step / job continues without release]
  F --> I[End job]
  H --> I
Loading

File-Level Changes

Change Details Files
Relax release workflow version check so releases are skipped instead of failing when Cargo.toml version is not updated.
  • Update the git diff check message when a version change is detected to a more explicit success log line.
  • Remove the explicit non-zero exit when Cargo.toml version is not updated and replace it with a warning log indicating the release will be skipped.
.github/workflows/release.yml
Bump crate version to 0.1.1 to reflect a new release.
  • Update the package version field from 0.1.0 to 0.1.1 in Cargo.toml.
  • Regenerate Cargo.lock to reflect the new crate version.
Cargo.toml
Cargo.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The version check step now only logs a warning without failing, but the subsequent Run release-plz step will still execute; if the intent is to truly skip the release when Cargo.toml wasn’t updated, you should gate that step with an if: condition (or set an output/exit 78) so the behavior matches the log message.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The version check step now only logs a warning without failing, but the subsequent `Run release-plz` step will still execute; if the intent is to truly skip the release when Cargo.toml wasn’t updated, you should gate that step with an `if:` condition (or set an output/`exit 78`) so the behavior matches the log message.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rodneyosodo rodneyosodo merged commit aae8a47 into main Jan 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant