chore: fix version check in release workflow to exit gracefully#2
chore: fix version check in release workflow to exit gracefully#2rodneyosodo merged 1 commit intomainfrom
Conversation
|
Warning Rate limit exceeded@rodneyosodo has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 1 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the release GitHub Actions workflow to no longer fail when Cargo.toml version is unchanged, and bumps the crate version from 0.1.0 to 0.1.1. Flow diagram for updated version check in release workflowflowchart TD
A[Start release workflow job] --> B[Set BASE_REF]
B --> C[Run git diff BASE_REF..HEAD on Cargo.toml]
C --> D{Was version line changed?}
D -- Yes --> E[echo ✅ Cargo.toml version was updated]
E --> F[Run release-plz]
D -- No --> G[echo ⚠️ Cargo.toml version was NOT updated - skipping release]
G --> H[Skip release-plz step / job continues without release]
F --> I[End job]
H --> I
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The version check step now only logs a warning without failing, but the subsequent
Run release-plzstep will still execute; if the intent is to truly skip the release when Cargo.toml wasn’t updated, you should gate that step with anif:condition (or set an output/exit 78) so the behavior matches the log message.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The version check step now only logs a warning without failing, but the subsequent `Run release-plz` step will still execute; if the intent is to truly skip the release when Cargo.toml wasn’t updated, you should gate that step with an `if:` condition (or set an output/`exit 78`) so the behavior matches the log message.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
What type of PR is this?
Related Tickets & Documents
Added/updated tests?
Added/updated documentation
Notes
Summary by Sourcery
Relax release workflow version check to skip releases when Cargo.toml version is unchanged and bump crate version.
Build:
Chores: