Skip to content

fix: use crypto.FromECDSA() to preserve leading zeros #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhkimqd merged 1 commit into from
Jan 19, 2026
Merged

fix: use crypto.FromECDSA() to preserve leading zeros #823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/fund/fund.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func getAddressesAndKeysFromKeyFile(keyFilePath string) ([]common.Address, []*ec
addresses[i] = util.GetAddress(context.Background(), privateKey)
log.Trace().
Interface("address", addresses[i]).
Str("privateKey", hex.EncodeToString(privateKey.D.Bytes())).
Str("privateKey", hex.EncodeToString(crypto.FromECDSA(privateKey))).
Msg("New wallet derived from key file")
}
log.Info().Int("count", len(addresses)).Msg("Wallet(s) derived from key file")
Expand Down Expand Up @@ -284,7 +284,7 @@ func generateWalletsWithKeys(n int) ([]common.Address, []*ecdsa.PrivateKey, erro
}
privateKeys[i] = pk
addresses[i] = crypto.PubkeyToAddress(pk.PublicKey)
log.Trace().Interface("address", addresses[i]).Str("privateKey", hex.EncodeToString(pk.D.Bytes())).Msg("New wallet generated")
log.Trace().Interface("address", addresses[i]).Str("privateKey", hex.EncodeToString(crypto.FromECDSA(pk))).Msg("New wallet generated")
}
log.Info().Int("count", n).Msg("Wallet(s) generated")

Expand All @@ -304,7 +304,7 @@ func saveToFile(fileName string, privateKeys []*ecdsa.PrivateKey) error {
address := crypto.PubkeyToAddress(privateKey.PublicKey)
data[i] = wallet{
Address: address.String(),
PrivateKey: hex.EncodeToString(privateKey.D.Bytes()),
PrivateKey: hex.EncodeToString(crypto.FromECDSA(privateKey)),
}
}

Expand Down