intents: add eip712 support via new IntentDataSignTypedData #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrislav
previously approved these changes
Dec 13, 2024
Member
patrislav
left a comment
patrislav
left a comment
There was a problem hiding this comment.
Looks good, just a small comment
intents/intent_data_sign_712_ext.go
Outdated
Comment on lines
76
to
78
| // A SignMessagePacket (intent) *MUST* be mapped to a regular "SignMessage" Sequence action, this means that | ||
| // it must adhere to the following rules: | ||
| // - the subdigest must match `SubDigest(chainID, Wallet, Digest(Message))` |
Member
There was a problem hiding this comment.
This comment doesn't make sense for SignTypedData, I'd remove it
Suggested change
| // A SignMessagePacket (intent) *MUST* be mapped to a regular "SignMessage" Sequence action, this means that | |
| // it must adhere to the following rules: | |
| // - the subdigest must match `SubDigest(chainID, Wallet, Digest(Message))` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on 0xsequence/ethkit#149