fix: clarify 'warnings as error' behaviour by splitting existing option into two different options #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2026
David-Wobrock
commented
Jan 4, 2026
Comment on lines
+48
to
+49
| | `--all-warnings-as-errors` | Treat all warnings as errors. | | ||
| | `--warning-as-error [MIGRATION_TEST_CODE [...]]` | Treat specified tests as errors. Specify migration test codes to handle as errors. | |
Collaborator
Author
There was a problem hiding this comment.
These rows changed.
…on into two different options
David-Wobrock
force-pushed
the
fix/warning-as-error-argument
branch
from
8b79dc1 to
80d43af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to tackle two open issues about the
--warnings-as-errorsoption behaviour being confusing.Fixes #269 and #320