Some code fixes and getting proper restricted kubeconfig structs - #2
Open
PrimalPimmy wants to merge 19 commits into
Open
PrimalPimmy wants to merge 19 commits into
PrimalPimmy wants to merge 19 commits into
Conversation
…ct#775) This PR adds SBOM information to README as well as [CLOMonitor](https://github.com/cncf/clomonitor) exemption configuration. This resolves nephio-project#551 and nephio-project#546
…rkflow Hardening codeql workflow
Author
|
Other PRs will follow for fixing:
|
#779 Main change here was to remove the use of the replace directive for porch in the go.mod files. Update the import paths. Minor code updates. Update the other dependencies to satisfy the existing codebase.
PrimalPimmy
force-pushed
the
spire-fixes
branch
3 times, most recently
from
August 2, 2024 03:42
26c7d74 to
2880aa9
Compare
Change approval controller PR Get to hit the api directly instead of reading from local cache. Adjust the reque duration to prevent race condition. During debugging the approval delay issue reported [here](https://github.com/nephio-project/nephio/issues/462) it became apparent that the packagerev being fetched was a cached version which didn't get updated for quite some time. To circumvent this, we are retrieving the PR using the apiReader interface which bypasses the local cache and hits the k8s api directly.
Co-authored-by: Rado Chmiel <r.chmiel@partner.samsung.com>
…ephio-project#525) Solves nephio-project#493 These changes will ensure we have nf deploy fn to apply de dupulication logic to NF Deploy Param Ref 1. Changes to Add Dependency to check if it already exist before adding. Thanks @gvbalaji for the code snippet in chat. 2. Added test cases to handle dependency, if same file is present multiple times. Its not in our use case, but its better to add that too. 3. Added changes to pipeline tests to ensure, if I run the NF Deploy Fn multiples after that, it doesn't break the idempotency principle.
Update pkgrev.get to use api Reader to bypass cache Additional logging Update kyaml versions to sync with porch version
PrimalPimmy
force-pushed
the
spire-fixes
branch
from
September 17, 2024 10:18
6f975bb to
4e618c3
Compare
There were some build fails that slipped trough tests resulting in broken build. Enabling 'always_run' as those are not long-running, just to be on safe side.
PrimalPimmy
force-pushed
the
spire-fixes
branch
from
September 20, 2024 02:13
b1b3497 to
60bb4c8
Compare
PrimalPimmy
force-pushed
the
spire-fixes
branch
from
February 11, 2025 16:31
10a28f1 to
3b9bd0c
Compare
PrimalPimmy
force-pushed
the
spire-fixes
branch
from
February 18, 2025 11:46
8b1896e to
2b7ffac
Compare
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR involves improving the process of generating restricted kubeconfigs for the spire-server to pick up