Skip to content

omit_resolver_fields also respects gqlgen.yml's config#3045

Draft
aereal wants to merge 1 commit into
99designs:masterfrom
aereal:omit-resolver-fields-respect-gqlgen-config
Draft

omit_resolver_fields also respects gqlgen.yml's config#3045
aereal wants to merge 1 commit into
99designs:masterfrom
aereal:omit-resolver-fields-respect-gqlgen-config

Conversation

@aereal

@aereal aereal commented May 6, 2024

Copy link
Copy Markdown

This PR will fix the #3044.

The omit_resolver_fields option that introduced by #2957 does not respect models.<model>.fields.<field>.resolver option, only schema directives are respected.
The models.<model>.fields.<field>.resolver option marks the field to be resolved with explit resolvers, so the omit_resolver_fields should respect also this option.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 75.011% (-0.02%) from 75.029%
when pulling 0044392 on aereal:omit-resolver-fields-respect-gqlgen-config
into 769632a on 99designs:master.

@StevenACoffman

Copy link
Copy Markdown
Collaborator

Hey, how's this proceeding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants